Dark Theme

A lightweight and easy-to-use password manager

Brought to you by: dreichl

#1974 Dark Theme

Milestone: KeePass_2.x

Status: closed

Owner: nobody

Labels: None

Priority: 5

Updated: 2020-07-07

Created: 2020-06-29

Creator: darkdragon

Private: No

Since the last mono update on Ubuntu (using dark theme for my system), the color of progress bars, title bar (for entries with Title, User Name, ...), highlight color and comments box (bottom with further infos) and status bar (footer at bottom) changed to black, while the font didn't change to white for highlighted entries and text in the comments box making it almost impossible to read. Other parts of the UI like main menu, tree/entries backgrounds do not respect the dark theme at all.

Discussion

Dominik Reichl - 2020-07-04

status: open --> closed

Priority: 7 --> 5
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dominik Reichl - 2020-07-04

KeePass lets the framework (Mono / .NET Framework) draw most of the UI. If the framework doesn't adhere to the system theme, this should be implemented there (it doesn't make sense that each and every application implements UI drawing on its own).

Thanks and best regards,
Dominik

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

darkdragon - 2020-07-04

So KeePass doesn't set any colors for the UI?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Paul - 2020-07-05

KeePass can set colours, but it doesn't actually draw them.

The clue to your problems is in your original post "mono update". Reverting mono should fix the issue.

cheers, Paul

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dominik Reichl - 2020-07-05

KeePass does not set custom colors for most of its controls. Especially, it does not set a custom color for title bars, text boxes (including highlight color), the notes box and the status bar.

Best regards,
Dominik

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

darkdragon - 2020-07-05

Is there some inheritance of text/font color? Because it is set to black where it should default to white according to the theme...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dominik Reichl - 2020-07-06

I'm not sure what you mean. It would of course be possible to create derived classes that override the colors, but in my opinion it would be much better if this would be fixed in Mono instead of KeePass (such that all applications benefit from it).

Best regards,
Dominik

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

darkdragon - 2020-07-07

Sorry for the confusion. I just wanted to confirm that KeePass doesn't set/overwrite any text/font colors before reporting this bug to mono.

mono-theming.png

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

darkdragon - 2020-07-07

I created an upstream issue at https://github.com/mono/mono/issues/20078.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Dominik Reichl - 2020-07-07

Great, thanks!

For reproducing the issues without KeePass, I've created a small test application:
https://keepass.info/filepool/Bug_WindowsFormsTestApp.zip
All controls in the dialog use the default colors, and the colors shown in the list view ('Window background', etc.) should fit together (i.e. light text on dark background or the other way around).

Best regards,
Dominik

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.