#74 Cleanup for Clear Undo on Save

closed-accepted
nobody
5
2007-03-02
2007-03-01
No

Moved the code to do the actual clear to UndoManager.bufferSaved() per Kazutoshi Satoda's suggestion. Also refactored the bufferSaved method to differentiate between reseting the start and end on a dirty and actions to be taken when a buffer is finished saving. Also removed now unneeded getUndoManager method.

Discussion

  • Anonymous - 2007-03-01

    Clear Undo Code Cleanup

     
  • Marcelo Vanzin

    Marcelo Vanzin - 2007-03-02
    • status: open --> closed-accepted
     
  • Marcelo Vanzin

    Marcelo Vanzin - 2007-03-02

    Logged In: YES
    user_id=75113
    Originator: NO

    Applied, rev #9059.

     
  • Matthieu Casanova

    Logged In: YES
    user_id=285591
    Originator: NO

    Hi, I am late but what was the reason of this patch ?
    It introduce a regression since the UndoManager must not depend on jEdit class.
    Can it be rollbacked ?

     
  • Kazutoshi Satoda

    Logged In: YES
    user_id=1483238
    Originator: NO

    I see the problem, but I don't want to rollback it because it contains
    some fix for other actual problems. See the summary of mailing in this
    post.
    http://www.nabble.com//forum/Permalink.jtp?root=18019443&post=18020223

    I made another patch to fix the dependency. I'll commit this after some
    tests. Comments are welcome.
    File Added: UndoManager_do_not_depend_on_jEdit.patch

     
  • Kazutoshi Satoda

    Logged In: YES
    user_id=1483238
    Originator: NO

    Committed UndoManager_do_not_depend_on_jEdit.patch in r12867.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks