Menu

#314 File Browser dynamic menu support

closed-accepted
None
5
2010-01-30
2010-01-23
No

The attached patch brings some minor changes to EditPlugin and VFSBrowser in order to support dynamic menu.
Right now the FSB only support the addition of static menu defined in properties plugin.classname.browser-menu and plugin.classname.browser-menu-item.
This adds support for plugin.classname.browser-menu.code=code to instantiate a DynamicMenuProvider.

This is needed by the new Launcher plugin I'm writing so that it can provide a menu which content depends on the selected items.

Discussion

  • Alan Ezust

    Alan Ezust - 2010-01-29

    I notice in the patch that another method is removed - also called getSelectedFiles but with different signature.
    Is that intentional? Did you verify that no plugins use it?

     
  • François Rey

    François Rey - 2010-01-29

    The method removed is private and belongs to a package private inner class. That should be enough to ensure removing it does not break anything.
    However the method is not all lost: it's now a public method of the outer class.

     
  • Alan Ezust

    Alan Ezust - 2010-01-30
    • assigned_to: nobody --> ezust
    • status: open --> closed-accepted
     
  • Alan Ezust

    Alan Ezust - 2010-01-30

    Committed 17147

     
  • François Rey

    François Rey - 2010-01-30

    As per k_satoda request for documentation, fold and @since tag, here is an incremental patch file.
    jEdit-EditPlugin-VFSBrowser-patch-fmjrey-20100130-browser-dyn-menu-support.txt

     

Log in to post a comment.

MongoDB Logo MongoDB