Re: [ jEdit-devel ] [PATCH] Console plugin to support ESCAPE key.

[Slava P. <sp...@gj...>]

burtonator wrote:
> 
> Slava Pestov wrote:
> >
> > Kevin,
> >
> > This is exactly the reason why the Console guidelines forbid changes
> > to be made without my consent.
> 
> There are no guidelines in CVS.  Where did you put them?

CVSROOT/guidelines/README.<plugin name>

> > - Makes the ConsoleFrame implement KeyListener, instead of creating
> >   a KeyHandler inner class like all my other code does
> 
> -1.  The problem with this is that both ConsoleOutputPane and
> ConsoleShellPane will have to have modified constructors (or override
> addKeyListener() ).  This would be a worse scenario IMO.  I would have
> to pass a KeyHandler to each constructor and since I already have an
> instance of ConsoleFrame this is more logical... but it is not perfect.

Then you can extend EnhancedFrame instead (which handles Enter/Escape
for you), and override the cancel() method, which is invoked when
Escape is pressed.

Slava