|
From: mike d. <md...@st...> - 2000-04-07 23:41:08
|
On Fri, 7 Apr 2000, Todd Papaioannou wrote: > >While a series of buttons doesn't look as pretty as tabs, it will be much > >more stable. Currently, I am finding bugs in buffer tabs on a regular > >basis. Also, it will be easier to implement more complicated behaviour, > >such as only showing buttons/tabs for recently edited buffers. > > Well, my 2p's worth is that I like buffertabs. It looks elegant. i don't think that the JButton implementation will necessarily look bad. > Are the problems in the BufferTabs code caused by stuff we can change, > or do they derive from bugs in Swing? If it's the latter, then I agree > with the change, but if it's the former, I think we should stick with > the tabs, and tough out the debugging. JTabbedPane is designed to be a container that can switch between child containers using a controller. the BufferTabs implementation attempts to use only a single JEditTextArea and moves it from pane to pane whenever the selection changes. this conflicts with the way the Caret is implemented in JEditTextArea and causes focus problems. having a separate controller component that is not also the container for the JEditTextArea is much cleaner. we only want one child component, so we should not use a selector that demands a different child for each selection. JTabbedPane is just not MVC enough to be that flexible. -md |