Re: [ jEdit-devel ] new EditBus messages

[Kevin A. B. <bu...@re...>]

Slava Pestov wrote:
> 
> Dirk,
> 
> I have added two messages to EditBus; ShowTokenInfo and ViewURL.
> I think you can guess what they are used for :-) They are loosely
> based on the corresponding messages in InfoViewer and JIndex,
> but are slightly more generic.
<snip>

I like it.  This way we don't have to duplicate code for C++/PERL etc.

Good job.... 

But this shouldn't throw an NPE... how about an IllegalArgumentException
(because that is what it is).  The NPE would just probably be thrown
anyway.

if(url == null)
	throw new NullPointerException("URL must be non-null");

would be:

if(url == null)
	throw new IllegalArgumentException("URL must be non-null");


--
Kevin A. Burton
Senior Software Engineer
Kendara.com