Re: [ jEdit-devel ] [ jedit-Plugin Central Submission-3540837 ] EditorConfigPlugin 0.3.1 -- Initial release

[Hong Xu <de...@ho...>]

On 2012/7/30 1:26, Jarek Czekalski wrote:
> W dniu 07/29/2012 04:34 PM, Hong Xu pisze:
>> On 07/29/2012 05:03 AM, Jarek Czekalski wrote:
>>> W dniu 07/28/2012 02:17 PM, Hong Xu pisze:
>>>>
>>>>>>>> 2. The compilation and building of the plugin does not meet our
>>>>>>>> automatization criteria. Simply running "ant dist" should build
>>>>>>>> the plugin with docs, without additional steps. We may consider
>>>>>>>> accepting some additional steps, but they must be given somewhere.
>>>>>>> Ok, I'll make changes.
>>>>> Still have compilation problems. I cloned, but don't have core
>>>>> classes. Did you try to address the automatization issue?
>>>>>
>>>>> "Basedir
>>>>> /usr/src/jedit/plugins/EditorConfig/editorconfig-core-py/java-binding
>>>>> does not exist"
>>>>>
>>>> What is the output of 'ls editorconfig-core-py/'? Are you sure you
>>>> have checked out the submodule?
>>>
>>> Our automatization build gives us only one step "ant dist".
>>>
>>
>> If you want to run without checking out the submodule explicitly, you
>> should clone with "--recursive" argument:
>>
>> git clone --recursive
>> git://github.com/editorconfig/editorconfig-jedit.git
>
> Hong, could you add a check to the build script that would perform more
> or less the following:
>
> if (submodule directory does not exist) then
>    print "run the command ... to get the necessary submodules"
>    fail

OK. I'll try to do it.
>
> But I have the following doubt considering submodules:
> After a year or so I may want to checkout the old 0.3.1 version of
> EditorConfig plugin. So I'll simply call this tag. How can we be sure,
> that the editorconfig submodule, that will be downloaded, will also be
> in the old version, from the time of releasing 0.3.1?
>

Yes. Submodule is also like a file, the revision of the submodule is 
recorded. if I update the submodule to a later version, I need to 
commit. So if I checkout tag v0.3.1 in the future, I will still get the 
current submodule version, but I need to run 'git submodule update' to 
update the submodule version to the specified version.

Hong