From: Dale A. <da...@gr...> - 2012-05-09 16:45:48
|
Yay! :) One other point -- the svn plugin code does a similar check ahead of calling the svn library. The library call is slower than I'd like, so doing the check ahead of time reduces the overall time significantly. This code is in place since version 1.6.1 of the svn plugin. On Wed, May 9, 2012 at 10:32 AM, Jarek Czekalski <jar...@po...>wrote: > > >> Comment By: Dale Anson (daleanson) > > Date: 2012-05-09 07:14 > > > > Message: > > Jarek, there isn't any C code in the svn plugin. > You must be right, Dale. They are jars only. Haven't thought about it :) > But I bet they are compatible in behaviour with its c origins. > > (20 minutes or more passed) > > I won :) > > } else if (ignoreTextMods || > (pathKind != null && > info.recordedSize != -1 && > info.recordedModTime != 0 && > (info.recordedModTime / 1000) == fileTime && > info.recordedSize == fileSize)) { > text_modified_p = false; > > org.tmatesoft.svn.core.internal.wc17.assembleStatus (line 340 in trunk) > > > > > ---------------------------------------------------------------------- > > > > Comment By: Jarek Czekalski (jarekczek) > > Date: 2012-05-09 02:39 > > > > Message: > > I analyzed svn code and it goes like this in libsvn_wc\status.c: > > > > else if (ignore_text_mods > > ||(dirent > > && info->recorded_size != SVN_INVALID_FILESIZE > > && info->recorded_mod_time != 0 > > && info->recorded_size == dirent->filesize > > && info->recorded_mod_time == dirent->mtime)) > > > > That is getStatus runs fast if the file sizes and modification times > match. > > No diffs in that case. As it seems to be the most frequent case, I think > PV > > may still check it at the repainting phase. > > > > Matthieu, please do svn revert -R * on your repository. That should reset > > the filestamps. Would pv run faster after that? > > > > ---------------------------------------------------------------------- > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > -- > ----------------------------------------------- > jEdit Developers' List > jEd...@li... > https://lists.sourceforge.net/lists/listinfo/jedit-devel > |