Menu
▾
▴
[ jEdit-devel ] [ jedit-Plugin Bugs-3452173 ] Whitepace Plugin: plugin options don't affect current buffer
|
From: SourceForge.net <no...@so...> - 2012-02-11 15:34:03
|
Plugin Bugs item #3452173, was opened at 2011-12-06 00:33 Message generated for change (Comment added) made by rschwenn You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3452173&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: WhiteSpace Group: None Status: Open Resolution: None Priority: 4 Private: No Submitted By: Alan Ezust (ezust) Assigned to: Nobody/Anonymous (nobody) Summary: Whitepace Plugin: plugin options don't affect current buffer Initial Comment: The action "remove trailing whitespace" doesn't seem to do anything. The checkbox state of the action appears to not be influenced by, nor does it seem to influence the corresponding checkbox option in the plugin option pane. Shouldn't they both (option and action) do the same thing? ---------------------------------------------------------------------- >Comment By: Robert Schwenn (rschwenn) Date: 2012-02-11 07:34 Message: +1 for: "Whitespace plugin options should affect all buffers except there are already other options with higher priority." Like Alan I think that's the way plugin options work in general. Other options with higher priority could be: - explicitly set buffer options - edit mode depending options - other? ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2011-12-09 09:45 Message: for my previous comment, s/checkbox/combobox. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2011-12-09 09:43 Message: If I am editing a file, and I want to see "indent" folding instead of "none", or even change the tab width from "4" to 2", I have my choice. I can go to global options - editing, and change the default settings for all modes, or I can set it for the current buffer in buffer options. In *either* case, I only need to check one checkbox and I see the change immediately. If you don't, that must mean you have overridden the setting before somehow, either with buffer options or with buffer-local properties. That's how it works in core. I just checked again and it still works that way. I expect it to work the same way in WhiteSpace. ---------------------------------------------------------------------- Comment By: Jarek Czekalski (jarekczek) Date: 2011-12-09 02:48 Message: If you compare with jedit global settings, then you're unfortunately not right. (Unfortunately because it makes correction of this unconvenience harder.) At least not about "tab width" settings. Things are a bit more complicated because there is also customization per mode possible, but let's say I have a buffer in mode M. I enter buffer options and set tab width to 3. It starts working immediately. So I go to global options and change tab width to 5 (globally) and to 7 for mode M. Still buffer works on tab width of 3. Whitespace plugin is consistent with this behaviour, although I would second several feature requests: 1. make per mode customization possible 2. add buttons Apply to current buffer, Apply to all buffers in Plugin Options 3. add checkbox Save as default in WhiteSpace Buffer Options All these things could be better done in core to provide such functionalities to all plugins having buffer options. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2011-12-08 08:40 Message: I still think it makes no sense. If i want to stop the WhiteSpace plugin from stripping off whitespaces on save, and it was already set for my current buffer, that means I have to un-check the current buffer settings *and also* the plugin options settings. That's one more checkbox than I think I should have to click. I want to be able to click just one checkbox, in the plugin options, and have it affect both defaults, and my current buffer. That is how things work when you change other settings under global options - editing. ---------------------------------------------------------------------- Comment By: Jarek Czekalski (jarekczek) Date: 2011-12-08 06:14 Message: Actually the word "default" is used everywhere in Plugin Options except section "On save actions". Here something needs to be done. It's hard to sneak words "by default" to this section. But something longer as a label above other components would do, like: "Default configuration for actions. Will not be applied to currently open buffers." ---------------------------------------------------------------------- Comment By: Jarek Czekalski (jarekczek) Date: 2011-12-07 23:56 Message: Alan, I just watched WhiteSpace settings. It's clearly said there that all are the defaults. E.g. "Show spaces by default". So I think there's no bug here. Would you close it or move to feature requests? ---------------------------------------------------------------------- Comment By: Jarek Czekalski (jarekczek) Date: 2011-12-06 23:42 Message: I accept the current idea which is: defaults are defaults current buffer has its own options I'm not the one to change the design. I can't see any maintainer, but Shlomy was interested in WhiteSpace lately. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2011-12-06 13:40 Message: If i change the setting in plugin options, shouldn't that ALSO change things for the current buffer?? ---------------------------------------------------------------------- Comment By: Jarek Czekalski (jarekczek) Date: 2011-12-06 12:04 Message: Now we understand each other :) Plugin options - defaults for files opened in future Show Whitespace buffer options - options applying to current buffer Plugin menu = copies Show Whitespace buffer options If you haven't compiled WS yourself, then you have a version before changes in interface. Changes were aiming at making interface more understandable. Actually it's only this new dialog: Show Whitespace buffer options. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2011-12-06 11:06 Message: Steps to reproduce. 1. install whitespace. 2. initially the action and the option are both un-checked. 3. Go to plugin options - whitespace - on save, check the option in plugin options. 4. look at whitespace's plugin menu. Notice it is NOT checked now. That's a bug. So what is it going to do? what the plugin option says, or what the drop-down menu says? The two checkboxes should always be consistent, no? ---------------------------------------------------------------------- Comment By: Jarek Czekalski (jarekczek) Date: 2011-12-06 10:53 Message: When you check it you make it active. When it's active it removes trailing spaces on buffer save. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2011-12-06 08:41 Message: The plugin option works fine. It is the checkbox action that confuses me. What does it do when you check it? What does it do when you un-check it? ---------------------------------------------------------------------- Comment By: Jarek Czekalski (jarekczek) Date: 2011-12-06 08:34 Message: Alan, have you noticed that it's in section "on save"? It works for me. If you didn't notice it, please judge whether it was your fault or something needs to be clearer. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=565475&aid=3452173&group_id=588 |