Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-3094044 ] C-style indentation fix
|
From: SourceForge.net <no...@so...> - 2012-01-10 07:57:09
|
Patches item #3094044, was opened at 2010-10-23 23:31 Message generated for change (Comment added) made by kpouer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3094044&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: texteditor Group: None >Status: Closed >Resolution: Invalid Priority: 5 Private: No Submitted By: Damien (kog13) Assigned to: Nobody/Anonymous (nobody) Summary: C-style indentation fix Initial Comment: This patch fixes an issue with c-style indenting caused by a multiline unaligned bracket followed immediately by an opening aligned bracket, such as splitting method parameters into multiple lines. In addition to the fix, it adds an option for double indent in the editing global options pane, which indents the next line by twice the indent size when inside an unclosed unaligned bracket. ---------------------------------------------------------------------- >Comment By: Matthieu Casanova (kpouer) Date: 2012-01-09 23:57 Message: The patch do not work ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2011-10-17 11:20 Message: are you here ? ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2011-03-01 03:54 Message: The exception is java.lang.ArrayIndexOutOfBoundsException: -1:1 at org.gjt.sp.jedit.TextUtilities.findMatchingBracket(TextUtilities.java:118) at org.gjt.sp.jedit.indent.CloseBracketIndentRule$AlignBracket.<init>(CloseBracketIndentRule.java:179) at org.gjt.sp.jedit.indent.CloseBracketIndentRule.apply(CloseBracketIndentRule.java:84) at org.gjt.sp.jedit.buffer.JEditBuffer.getIdealIndentForLine(JEditBuffer.java:1137) at org.gjt.sp.jedit.buffer.JEditBuffer.indentLine(JEditBuffer.java:1014) at org.gjt.sp.jedit.buffer.JEditBuffer.indentLines(JEditBuffer.java:988) at org.gjt.sp.jedit.textarea.TextArea.indentSelectedLines(TextArea.java:4475) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.gjt.sp.jedit.bsh.Reflect.invokeMethod(Reflect.java:134) at org.gjt.sp.jedit.bsh.Reflect.invokeObjectMethod(Reflect.java:80) at org.gjt.sp.jedit.bsh.Name.invokeMethod(Name.java:855) at org.gjt.sp.jedit.bsh.BSHMethodInvocation.eval(BSHMethodInvocation.java:75) at org.gjt.sp.jedit.bsh.BSHPrimaryExpression.eval(BSHPrimaryExpression.java:102) at org.gjt.sp.jedit.bsh.BSHPrimaryExpression.eval(BSHPrimaryExpression.java:47) at org.gjt.sp.jedit.bsh.BSHBlock.evalBlock(BSHBlock.java:130) at org.gjt.sp.jedit.bsh.BSHBlock.eval(BSHBlock.java:80) at org.gjt.sp.jedit.bsh.BshMethod.invokeImpl(BshMethod.java:362) at org.gjt.sp.jedit.bsh.BshMethod.invoke(BshMethod.java:258) at org.gjt.sp.jedit.bsh.BshMethod.invoke(BshMethod.java:186) at org.gjt.sp.jedit.BeanShellFacade.runCachedBlock(BeanShellFacade.java:225) at org.gjt.sp.jedit.BeanShell.runCachedBlock(BeanShell.java:423) at org.gjt.sp.jedit.BeanShellAction.invoke(BeanShellAction.java:73) at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:342) at org.gjt.sp.jedit.gui.InputHandler.invokeAction(InputHandler.java:307) at org.gjt.sp.jedit.gui.DefaultInputHandler.handleKey(DefaultInputHandler.java:197) at org.gjt.sp.jedit.input.AbstractInputHandler.processKeyEventKeyStrokeHandling(AbstractInputHandler.java:401) at org.gjt.sp.jedit.gui.InputHandler.processKeyEvent(InputHandler.java:151) at org.gjt.sp.jedit.textarea.TextArea.processKeyEvent(TextArea.java:4675) at java.awt.Component.processEvent(Unknown Source) at java.awt.Container.processEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source) at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source) at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source) at java.awt.Component.dispatchEventImpl(Unknown Source) at java.awt.Container.dispatchEventImpl(Unknown Source) at java.awt.Window.dispatchEventImpl(Unknown Source) at java.awt.Component.dispatchEvent(Unknown Source) at java.awt.EventQueue.dispatchEvent(Unknown Source) at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source) at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.pumpEvents(Unknown Source) at java.awt.EventDispatchThread.run(Unknown Source) ---------------------------------------------------------------------- Comment By: Damien (kog13) Date: 2011-02-28 15:45 Message: Okay, I'll look into debugging the patch. What was the exception? ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2011-02-28 05:01 Message: Ok I understand, this patch seems interesting but I have some problems : first one in java mode : if (true) { } The last closing bracket is not aligned. And if I select all that code snippet and try to indent it, I have an exception ---------------------------------------------------------------------- Comment By: SourceForge Robot (sf-robot) Date: 2011-02-28 04:20 Message: This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Damien (kog13) Date: 2011-02-18 07:24 Message: Since I don't trust sourceforge's comments section to indent code correctly, I attached a couple screenshots of what I mean. 'bad.png' is what the current indentation produces, and 'good.png' is the ideal. I'm assuming that this isn't a problem for most jEdit developers who put brackets on their own lines, which works fine. Putting the bracket on the same line also works fine, provided that the declaration the bracket is opening doesn't span more than a single line. My patch should fix it so that same-line brackets always work, regardless of how many lines the declaration spans. ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2011-02-14 03:30 Message: Hi, could you provide an example of the problem ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3094044&group_id=588 |