[ jEdit-devel ] [ jedit-Plugin Patches-2831560 ] SideKick: replace Asset usages with IAsset

[SourceForge.net <no...@so...>]

Plugin Patches item #2831560, was opened at 2009-08-03 08:31
Message generated for change (Settings changed) made by ezust
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=2831560&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Denis Dzenskevich (leshij)
>Assigned to: Dale Anson (daleanson)
Summary: SideKick: replace Asset usages with IAsset

Initial Comment:
In SideKickTree and SourceTree files sidekick object is checked for being Asset, not IAsset, which resulted in IAsset.getIcon was not used when object implemented IAsset directly rather then by extending Asset.
Also, I've done a couple of minor improvements since anyway I'm touching these files.

----------------------------------------------------------------------

Comment By: Wormbo (wormbo)
Date: 2010-03-21 07:11

Message:
One Asset reference is still left in the current SVN revision: (sorry,
can't attach files, but you get the idea)

Index: sidekick/enhanced/SourceTree.java
===================================================================
--- sidekick/enhanced/SourceTree.java	(revision 17504)
+++ sidekick/enhanced/SourceTree.java	(working copy)
@@ -52,7 +52,6 @@
 import org.gjt.sp.jedit.gui.KeyEventTranslator;
 import org.gjt.sp.jedit.msg.BufferUpdate;
 
-import sidekick.Asset;
 import sidekick.IAsset;
 import sidekick.SideKickTree;
 
@@ -237,7 +236,7 @@
             if ( node.getParent() == null ) {
                 setIcon(
org.gjt.sp.jedit.browser.FileCellRenderer.fileIcon );
             }
-            if ( nodeValue instanceof Asset ) {
+            if ( nodeValue instanceof IAsset ) {
                 IAsset _asset = ( IAsset ) node.getUserObject();
                 setIcon( _asset.getIcon() );
                 setText( _asset.getShortString() );

----------------------------------------------------------------------

Comment By: Shlomy Reinstein (shlomy)
Date: 2009-09-15 10:31

Message:
Thanks for the patch, but can you update it to work with the latest SVN
version of sidekick?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997937&aid=2831560&group_id=588