Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-3153909 ] Hypersearch Fix
|
From: SourceForge.net <no...@so...> - 2011-01-13 02:17:55
|
Patches item #3153909, was opened at 2011-01-09 20:17 Message generated for change (Comment added) made by evanpw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3153909&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Evan Wright (evanpw) Assigned to: Nobody/Anonymous (nobody) Summary: Hypersearch Fix Initial Comment: This is a fix for bug #3134951 - "Open file via hyper search overrides result line". The regression occurred because HyperSearchResult got updated to the new threading API, while EditPane was still using runInAWTThread, so the caret updates got run in the wrong order. ---------------------------------------------------------------------- >Comment By: Evan Wright (evanpw) Date: 2011-01-12 21:17 Message: Also works on Ubuntu 10.04.1 with OpenJDK 6u20, and on Vista with JRE 6u5. ---------------------------------------------------------------------- Comment By: Evan Wright (evanpw) Date: 2011-01-12 15:24 Message: I'm Mac OSX 10.6.5 running "Java for Mac OS X 10.6, Update 3" (equivalent to JDK 6u22). I applied the patch to trunk r19187, and used the same process you described above. No failures in a few dozen trials. It also seems to work correctly with OpenJDK6. ---------------------------------------------------------------------- Comment By: Kazutoshi Satoda (k_satoda) Date: 2011-01-12 12:44 Message: In detail, I set -nosettings, and used README.SRC.txt in jEdit source tree, and did Hypersearch for the word "This" at line 3. After that, I repeated ... - Ctrl+Home (bring the cursor to the beginning of the file), - Ctrl+W (closing the buffer), - clicking the first occurrence of floating Hypersearch dockable. In working case, the cursor goes to line 3 and the word "This" is selected. In failing case, the cursor goes to the beginning of the file. If you still couldn't see the failing case, please report your environment. ---------------------------------------------------------------------- Comment By: Evan Wright (evanpw) Date: 2011-01-12 00:04 Message: Did you do anything specific in the failed trials? I'm on a different setup here, but I've done a few hundred trials with different parameters (file size, cpu load, adding explicit delays in the code), and I haven't been able to get it to fail. ---------------------------------------------------------------------- Comment By: Kazutoshi Satoda (k_satoda) Date: 2011-01-09 21:21 Message: Thank you for the patch. But unfortunately, it seems incomplete. I tried the patch against jEdit trunk r19187, JDK 6u23, Windows XP. It worked 4 times for 10 trials. Sorry but I don't have enough time now to give more analysis. I'll take a deeper look later. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=3153909&group_id=588 |