Menu
▾
▴
[ jEdit-devel ] [ jedit-Plugin Patches-2959723 ] Paste into Find dialog does nothing on Mac
|
From: SourceForge.net <no...@so...> - 2010-02-27 18:11:51
|
Plugin Patches item #2959723, was opened at 2010-02-26 17:44 Message generated for change (Comment added) made by scarlac You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=997937&aid=2959723&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: AshZeroOne (eobusek) Assigned to: Seph Soliman (scarlac) Summary: Paste into Find dialog does nothing on Mac Initial Comment: I found some info on this. I loaded jEdit with no plugins and the problem went away. I then tried individual plugins until I found the one causing the problem: MacOSX. I looked at the code and suspected something going on with the Look and Feel, so I started trying different L&F settings. The problem occurs for the CDE/Motif and the Mac OS X L&Fs. I got the Mac OS X L&F working by changing the line: if (lf.equalsIgnoreCase("apple.laf.aqualookandfeel") == false) to if (lf.equalsIgnoreCase("com.apple.laf.aqualookandfeel") == false) in the function start() of the MacOSXPlugin class. Further testing shows that paste doesn't work for CDE/Motif even with the MacOSX plugin NOT loaded. So that seems to be a separate issue. Sorry if I'm doing this wrong - first time I've tried to fix something. Here is the diff: ernest-mac:trunk ernest$ svn diff Index: jars/MacOSX/macosx/MacOSXPlugin.java =================================================================== --- jars/MacOSX/macosx/MacOSXPlugin.java (revision 17378) +++ jars/MacOSX/macosx/MacOSXPlugin.java (working copy) @@ -65,9 +65,9 @@ { // Fix key bindings for OS X for anything other than Aqua LNF // See: http://lists.apple.com/archives/java-dev/2008/Apr/msg00209.html - if (lf.equalsIgnoreCase("apple.laf.aqualookandfeel") == false) + if (lf.equalsIgnoreCase("com.apple.laf.aqualookandfeel") == false) { - Log.log(Log.DEBUG, this, "Fixing keybindingds on current LNF"); + Log.log(Log.DEBUG, this, "Fixing keybindings on current LNF '" + lf + "'"); UIDefaults uid = UIManager.getLookAndFeelDefaults(); fixMacKeyBindings(uid); } ---------------------------------------------------------------------- >Comment By: Seph Soliman (scarlac) Date: 2010-02-27 19:11 Message: I just discovered that my properties was set incorrect compared to the proper classpath for the LNF reported by both jvm 1.4.2, 1.5 and 1.6. It was missing the prefix "com.". I am unable find the cause of this incorrect setting. The fix is to make a proper check if the current environment is the native one, not on the actual name. Fixed in revision #17395 in trunk. Best Seph ---------------------------------------------------------------------- Comment By: Seph Soliman (scarlac) Date: 2010-02-27 18:08 Message: Please provide some system specifications, specifically jEdit version, JVM version, plugin version and OS X version. It works fine on all machines i've tested on, and it works well both in the Metal and Aqua LNF. It sounds like you are running the wrong JVM version, since the namespace you are trying to test for changed in newer versions. Regards Seph ---------------------------------------------------------------------- Comment By: Kazutoshi Satoda (k_satoda) Date: 2010-02-27 10:44 Message: Moving to Plugin Patches tracker, and assigning to Seph since this seems related to a report which was closed as Invalid. https://sourceforge.net/support/tracker.php?aid=2956477 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=997937&aid=2959723&group_id=588 |
