Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-2871624 ] Patch for TokenMarker.java
|
From: SourceForge.net <no...@so...> - 2009-10-03 03:02:13
|
Patches item #2871624, was opened at 2009-10-01 19:28 Message generated for change (Comment added) made by daleanson You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2871624&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: texteditor Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Dale Anson (daleanson) Assigned to: Nobody/Anonymous (nobody) Summary: Patch for TokenMarker.java Initial Comment: This follows discussion on the jedit-devel list: https://sourceforge.net/mailarchive/message.php?msg_name=8569d5150909291403h5cc6a814nc3dbc46e6b0fe85d%40mail.gmail.com Occasionally, TokenManager.java throws a NPE from line 294. After some research, I found that 'context.parent' can be null. In case it is, the patch simply uses the same context since no parent context is available. I don't have a reproducible test case for this, but I do get it fairly often, usually several times a day. I've applied the patch locally, and will run it for a week or so, and if no one finds any problems, I'll go ahead and commit this. ---------------------------------------------------------------------- >Comment By: Dale Anson (daleanson) Date: 2009-10-02 21:02 Message: More research -- this patch is inadequate. The problem is caused by TokenMarker.java not being thread safe. This patch does not address thread safety. I'll try to come up with a better patch that makes TokenMarker thread safe. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2871624&group_id=588 |