Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-2844750 ] line height correction (disappearing underscores)
|
From: SourceForge.net <no...@so...> - 2009-08-26 17:41:49
|
Patches item #2844750, was opened at 2009-08-26 08:46 Message generated for change (Comment added) made by blueyed You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2844750&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: texteditor Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Suraj Kurapati (cyzsuraj) Assigned to: Nobody/Anonymous (nobody) Summary: line height correction (disappearing underscores) Initial Comment: Attached is a patch (against SVN r16059) which solves problem of underscores disappearing when the cursor is moved up and down the lines of the TextArea with the "DejaVu Sans Mono" at 15pt in jEdit from SVN trunk (r16059) under openjdk6-1.5-2-i686. The root cause was the underscore in this particular font descends below lineHeight and appears on the first pixel of the next line. So when the next line is drawn, the underscore of the current line is painted-over and it disappears. The solution used in the patch is to always draw one extra line above the first line being repainted, so that any underscores in the extra above line are preserved during the repaint. Thanks for your consideration. ---------------------------------------------------------------------- Comment By: daniel hahler (blueyed) Date: 2009-08-26 19:41 Message: I confirm this bug, using DejaVu Sans 12 Plain. Also the patch fixes it for me and I intend to commit it, if nobody speaks up against it. ---------------------------------------------------------------------- Comment By: Suraj Kurapati (cyzsuraj) Date: 2009-08-26 08:52 Message: Here two are screencasts showing before & after the patch: http://snk.tuxfamily.org/tmp/before.gif http://snk.tuxfamily.org/tmp/after.gif ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2844750&group_id=588 |
