Menu
▾
▴
[ jEdit-devel ] [ jedit-Bugs-2317540 ] PM ActivationPane: optional dependencies on select
|
From: SourceForge.net <no...@so...> - 2009-01-01 23:22:40
|
Bugs item #2317540, was opened at 2008-11-20 05:33 Message generated for change (Comment added) made by ezust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100588&aid=2317540&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: plugin manager Group: None Status: Open Resolution: None Priority: 7 Private: No Submitted By: Ben Golding (bgolding) Assigned to: Nobody/Anonymous (nobody) Summary: PM ActivationPane: optional dependencies on select Initial Comment: To reproduce: * Deselect all plugins to disable them * Select Console (checkbox) Error message: "The following plugin could not be loaded: C:\Program Files\jEdit\jars\ProjectViewer.jar: Requires version 0.9.4 or later of CommonControlsPlugin, but CommonControlsPlugin is not installed" Actually the message is wrong - CommonControlsPlugin is installed. Note that selecting only ProjectViewer (all others disabled) does not appear to need CommonControlsPlugin. --- Win XP + SP3 jEdit 4.3pre16 Java 1.6.0_07 CommonControls 0.9.4 Console 4.3.8 ErrorList 1.7 ProjectViewer 2.1.3.7 --- (other plugins, may not be relevant) Beauty 0.3.0 BufferTabs 1.1.0 Perforce Plugin 0.2.4 PerlSideKick 0.6 SideKick 0.7.6 XercesPlugin 2.9.1 XML 2.0.9 ---------------------------------------------------------------------- >Comment By: Alan Ezust (ezust) Date: 2009-01-01 15:22 Message: oops. that last comment was actually bug # 1262390 which is related to this, but should be fixed first. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2009-01-01 15:20 Message: Furthermore, the Plugin Manager Unload feature needs to be fixed too. When someone unloads a plugin that was loaded, and hooked up to another plugin that lists it as an optional dependency, then when you unload one, you should also unload the dependent plugins and force them to start up again without it. For example, Console and Projectviewer: if I have them both running, and then I unload PV, it should also unload Console, forcing me to restart it. ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2008-11-25 00:40 Message: I agree with Shlomy, [1] seems more reasonable to me, although the dialog is a good option. ---------------------------------------------------------------------- Comment By: Shlomy Reinstein (shlomy) Date: 2008-11-25 00:34 Message: I suggest either [1], or to show a dialog asking the user if the optional dependencies should be enabled as well. ---------------------------------------------------------------------- Comment By: Ben Golding (bgolding) Date: 2008-11-25 00:08 Message: I suggest [1] or [2] would be the best solution. I think [2] is less confusing. [3] would require <N> .props files to be updated because you added one dependency to a plugin which is itself a dependency of others, so probably not a good idea. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2008-11-24 15:32 Message: This is a bug in jEdit core, actually. According to Console.props, it has an "optional dependency" which means that if PV is not available, Console should still start up. However, if it is available but not selected, the behavior of Plugin Manager is incorrect (or incompletely specified). Console should (I suppose) load and activate the optional dependent plugin. If it does that, then it should also go through all of the plugin's dependencies and activate them first. So a proper behavior for plugin manager is to either 1. ignore optional dependencies (not activate them) 2. activate optional dependences (and all of their dependencies too, recursively). 3. Fix Console to add "optional CommonControls" to its list of optional dependencies, and document core that optional dependencies need to be completely (recursively) listed in the .props file? plugin.console.ConsolePlugin.depend.3=optional plugin projectviewer.ProjectPlugin 2.1.1 Stranger still, ProjectViewer does require CommonControls, so by selecting that, the CommonControls plugin should also be "activated". ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100588&aid=2317540&group_id=588 |