Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-2296738 ] [1936518] File/Directory properties dialog
|
From: SourceForge.net <no...@so...> - 2008-11-26 20:18:09
|
Patches item #2296738, was opened at 2008-11-16 07:07 Message generated for change (Comment added) made by vladimirr You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2296738&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: VladimirR (vladimirr) Assigned to: Nobody/Anonymous (nobody) Summary: [1936518] File/Directory properties dialog Initial Comment: Here's the patch for a File/Directory properties dialog. It adds the "properties" entry to the context menu of the file browser, which opens a dialog showing the file's/directory's name, path, date of last modification, size, and accesibility, for a single file/directory or the path and total size of the multiple selected items. Please feel free to comment this patch, since it's for a scool project, and we need some feedback. ---------------------------------------------------------------------- >Comment By: VladimirR (vladimirr) Date: 2008-11-26 20:18 Message: I've uploaded the fixed patch, with the next changes: - the properties entry only shows up in the context menu, when there's at least one selected item - the string properties have been moved to the jedit_gui.props file - the typo has been fixed About the checkboxes: It would require Java6 to be able to change the readablity/writeablity to both ways (java <6 only allows to invoke rights), that's why the checkboxes are read-only. Also, you're able to obtain the information about modification date and filesize, even if you have no access to the file. I guess, this happens, becouse you read those from the file sytem, and not the file itself (i was able to see the size, and date for /etc/shadow as a limited user). File Added: FilePropertiesDialog_v2.patch ---------------------------------------------------------------------- Comment By: Zoltan Balog (ali_g) Date: 2008-11-25 09:14 Message: Thanks to observe our "mini" project and your advices. The bug will fix as soon as possible (maybe at this moment) and we will discuss the checkbox, what you mentioned. ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2008-11-25 06:07 Message: I see a few problems: When right-clicking on a directory in the top half of the file browser, then choosing "Properties" from the context menu, I get a bean shell error: java.lang.ArrayIndexOutOfBoundsException: 0 at org.gjt.sp.jedit.gui.FilePropertiesDialog.<init>(FilePropertiesDialog.java:51) at org.gjt.sp.jedit.browser.VFSBrowser.fileProperties(VFSBrowser.java:864) ... The string properties in FilePropertiesDialog should be moved to jedit_gui.props so that others can localize for their language. Also, Attribute is misspelled as Atribute. I'm curious about the "Readable" and "Writable" checkboxes. Would you ever be able to show properties for a file that is not readable? Neither of these checkboxes are clickable, should at least the "Writable" checkbox function so the user can change this value? Otherwise, this looks good, the coding standard follows the jEdit standard and the patch applied without error. Thanks! ---------------------------------------------------------------------- Comment By: Norbert Tóth (totka) Date: 2008-11-23 19:42 Message: I took 3 screenshots from this feature: * Context menu: http://img113.imageshack.us/my.php?image=contexttk6.png * If you select one file, you see this FileProperties window: http://img510.imageshack.us/my.php?image=filepropvw6.png With editing the name's textfield and click on the OK button, you can rename the file. * If you select more files, you see this FileProperties windows: http://img45.imageshack.us/my.php?image=filespropjn8.png ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2296738&group_id=588 |
