Re: [ jEdit-devel ] Removing -Xms JVM option

[Vampire <Vam...@gm...>]

Some thoughts:

1. Your patch does NOT include all occurences, so something was wrong 
with your search. At least jedit.bat also includes this option and that 
file is not in your revision 14000 or in your patch file.

2. The heap size is not trimmed at all iirc, that is why the initial 
size is also a kind of minimum limit. But this XMS limit is not only 
important for startup. If you have a lower heap size, you get garbage 
collections more often, because before increasing the heap size the JVM 
first tries to free memory through garbage collection. Only if the 
garbage collection is not able to free enough memory, the heap size is 
increased which also is a time intensive operation that can be saved by 
a reasonable default value for XMS. If you have a reasonable value for 
XMS, you can also reduce the amount of garbage collections and thus 
improve the performance of jEdit a second time. And in these days where 
one has RAM in the range of GiBs, I think that 64 MB of "minimum" heap 
size is ok if you gain more performance for that. I even mainly remember 
voices that say that our memory footprint is fine, but not really voices 
that complain about the memory footprint.

3. "and run and run full GC manually.": You cannot run GC manually. You 
can just ask the JVM politely to please run GC if she likes to. There is 
no guarantee whats-o-ever that System.gc() or Runtime.gc() do anything 
at all.

4. The places where the command lines are explicitly are reduced to a 
minimum already. If you call the jEdit.bat from the registry places, a 
black "DOS-box" pops up and this cannot be prevented, thus the explicit 
command line in the registry like Kazutoshi said already. The jEdit.bat 
file is thought for command line usage.

5. I don't really see the point in using Launch4j. It works fine like it 
is. And what is your problem with file-type associations? Just associate 
the file-type to the jedit.bat file. I don't really see how Launch4j 
should improve installation or file-type association.

Regards
Vampire

Kazutoshi Satoda schrieb:
> Hi Eric,
>
> Eric Berry wrote:
>   
>>>> My jEdit starts up and takes around 33M just to run.
>>>>         
> (snip)
>   
>> It's a trunk build as of about a week ago.
>>     
>
> It sounded too large for me, but, possible if you have some plugins
> I don't use, or some files are loaded on startup.
>
>   
>> I mean real usage (installed plugins, editing of files, etc...), not startup
>> so many times. Real editing. Eg. X% of users have on average 5 files open,
>> and 3 plugins  installed, and the heapsize is (on average) 12M. This would
>> give us a reasonable default value to start with right?
>>     
>
> I think it is not relevant to set "-Xms" by default, because the actual
> heap size is so different among users, and the heap automatically glows
> as needed.
>
>   
>>>> As for the values being all over the place, maybe we should re-examine the
>>>> way the installer works? Perhaps we should have basically 3 startup
>>>> scripts
>>>> and just have the install pointers to those.
>>>>         
>>> Sorry but I couldn't understand this part. What do "3 startup scripts"
>>> mean?
>>>       
>> Startup scripts as in .bat, .sh, and Info.plist files. :)
>>     
>
> I think Windows installation could be better by bundling a native
> jedit.exe created by Launch4j. It has configured to use a separated
> .ini file to specify the JVM options.
> http://launch4j.sourceforge.net/
> http://launch4j.sourceforge.net/docs.html#Additional_jvm_options
>
> It is working fine on my local. This also makes Windows file type
> association far easier. I'll make an actual patch to make this, probably
> after the release of 4.3pre16. It might be in 4.3pre16, with some luck.
>