From: SourceForge.net <no...@so...> - 2008-09-08 09:29:14
|
Patches item #2096752, was opened at 2008-09-06 12:02 Message generated for change (Comment added) made by kpouer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2096752&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Dakshinamurthy Karra (kdmurthy) Assigned to: Matthieu Casanova (kpouer) Summary: Embeddable text area Initial Comment: The attached patch fixes some bugs and makes it easier to embed a text area into an application. I tried to follow the same conventions as the other sources. I hope I did a decent job ;-). I also tried to avoid breaking public API from the classes - except in the obvious cases. Note that the patch for build.xml is being added another tracker item, since SF does not allow attaching multiple files and eclipse does not allow creating a patch using a dir & file. Detailed changes are as follows: 1. actions.xml Changed call to Registers.getRegisterStatusPrompt to jEdit.getRegisterStatusPrompt 2. JEditBuffer.java added a setUndoLimit() method. 3. jEdit.java changed createTextArea() to use the new constructor from text area added getRegisterStatusPrompt() method used from actions.xml 4. Registers.java moved getRegisterStatusPrompt() to jEdit 5. ModelProvider.java loadMode() changed to get the contents from resource if looking for a file fails. This is done so that the standalone jedit-textarea.jar can be used as it is. 6. JEditTextArea.java pulled-up popup related functions to TextArea 7. Added StandaloneTextArea.java - a subclass of TextArea 8. textarea.actions.xml Cleaned up. Removed jEditpane calls and calls specific to JEditTextArea (like showLineNumberDialog). 9. TextArea.java Removed the constructor that accepts insideJEdit parameter Created initInputHandler() to initialize the input handler from outside. (used in JEdit#createTextArea) Added popup menu code from JEditTextArea (pulled up) Moved main() function to StandaloneTextArea 10. TextAreaMouseHandler.java Added the code to call handlePopupTrigger 11. TextAreaPainer.java Removed the call to textArea.propertiesChanged in setFont(). 12. JEditBuffer 13. build.xml Added modes/*.xml, Registers.java, HistoryModel.java, HistoryModelSaver.java to textarea/src Changed Main-Class to StandaloneTextArea ---------------------------------------------------------------------- >Comment By: Matthieu Casanova (kpouer) Date: 2008-09-08 11:29 Message: Logged In: YES user_id=285591 Originator: NO Hi, I don't have the same problem with the trunk, do you use a special configuration ? Could you submit a bug report with that exception ? ---------------------------------------------------------------------- Comment By: Dakshinamurthy Karra (kdmurthy) Date: 2008-09-08 11:20 Message: Logged In: YES user_id=156777 Originator: YES I did some digging. Can someone have a look at Chunk.java? There was a modification of changing createGlyphVector() to layoutGlyphVector() that is causing painting problems and illegalArgumentError in the latest code from SVN. Reverting the change solves the problem. ---------------------------------------------------------------------- Comment By: Dakshinamurthy Karra (kdmurthy) Date: 2008-09-08 09:13 Message: Logged In: YES user_id=156777 Originator: YES I pulled out the changes from SVN. I find that the textarea painting is broken. JFYI. ---------------------------------------------------------------------- Comment By: Dakshinamurthy Karra (kdmurthy) Date: 2008-09-07 08:19 Message: Logged In: YES user_id=156777 Originator: YES Thanks. I just realized the buffer related properties (like tabSize, indentSize) are not propagated to the buffer - I think it is valid for jEdit since you can have local buffer properties. Can we assume that all buffer properties are prefixed with 'buffer.'? And those properties can be propagated in StandaloneTextArea's propertiesChanged() to the buffer? ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2008-09-07 00:02 Message: Logged In: YES user_id=285591 Originator: NO Hi, thanks for your patch, I'm starting testing it ---------------------------------------------------------------------- Comment By: Dakshinamurthy Karra (kdmurthy) Date: 2008-09-06 13:56 Message: Logged In: YES user_id=156777 Originator: YES The patch is not very big except the refactoring of TextArea.java. All others are small ones. I also noted that the patch added a vi tmp file into it - that can be safely removed. As for the problem goes, the current standalone textarea has hardcoded for most of the configurable parameters. The patch that I provided allows for the configuration to be done from outside. Another must-need feature is the ability to enhance the popup menu from the application side. That is also provided. A few issues of missing classes have been resolved. If you have any specific query, I will be happy to answer. ---------------------------------------------------------------------- Comment By: Kazutoshi Satoda (k_satoda) Date: 2008-09-06 13:15 Message: Logged In: YES user_id=1483238 Originator: NO While I don't need embeddable text area, but with a quick glance to this patch, I think this will be hard to review (and accept) because the change is too large. It would be better if you break the patch into small parts with descriptions for each about what a concrete problem it solves. It may require some times, but a patch is hardly acceptable without concrete problem to solve. ---------------------------------------------------------------------- Comment By: Dakshinamurthy Karra (kdmurthy) Date: 2008-09-06 12:44 Message: Logged In: YES user_id=156777 Originator: YES Hi, May I request the developers to give this patch a little higher priority. I am planning for a new beta release of Marathon sometime next week and it will be nice if I can integrate textarea into it by that time. Feel free to contact me if you need any clarifications. Thanks and Regards KD ---------------------------------------------------------------------- Comment By: Dakshinamurthy Karra (kdmurthy) Date: 2008-09-06 12:04 Message: Logged In: YES user_id=156777 Originator: YES File Added: patch-build.txt ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=2096752&group_id=588 |