Re: [ jEdit-devel ] Disabling FastRepaintManager

[Matthieu C. <cho...@gm...>]

Hi, I just did the same test again :

on Windows XP with a E6700
Using the following JVMs : 1.6_02 and 1.6_10

Test 1 : scroll 3 lines
Test 2 : scroll to the end of the buffer

  Test

JDK

FastRepaintManager

Total



1

1.6_10

On

5009898

TextAreaPainter: repainting 3 lines took 382918/202285/4424695 ns

1

1.6_10

Off

372028

TextAreaPainter: repainting 25 lines took 997/371031 ns

1

1.6_02

On

2390177

TextAreaPainter: repainting 3 lines took 288095/192586/1909496 ns

1

1.6_02

Off

3741577

TextAreaPainter: repainting 25 lines took 1184/3740393 ns

2

1.6_10

On

3531712

TextAreaPainter: repainting 25 lines took 4691/1074185/2452836 ns

2

1.6_10

Off

446047

TextAreaPainter: repainting 25 lines took 1154/444893 ns

2

1.6_02

On

3031481

TextAreaPainter: repainting 25 lines took 5895/1191200/1834386 ns

2

1.6_02

Off

4319533

TextAreaPainter: repainting 25 lines took 1207/4318326 ns

So I can see that removing the FastRepaintManager is very good when using
1.6_10 but is bad on 1.6_02.

Matthieu

On Sun, Aug 31, 2008 at 3:09 AM, Matthieu Casanova <cho...@gm...>
wrote:
> On Sat, Aug 30, 2008 at 11:52 AM, Kazutoshi Satoda
> <k_s...@f2...> wrote:
>> Matthieu Casanova wrote:
>>>
>>> Hi, I'm not at homeand cannot test your patch but it could be and idea
>>> to test, a better solution would be to add an option (maybe in Debug
>>> class), se we can enable and disableit easily and it will be easy to
>>> do comparison.
>>> would it be possible
>>
>> That's a good idea to make speed comparison. Done in r13454. Thanks.
>>
>> But I still want to drop FastRepaintManager completely, because I found
>> that it's not fast at all, at least in my box.
>>
>> --
>> k_satoda
>>
>
> Hi, it seems I'm unable to reproduce your speedup here
> on Linux, using Sun's JDK 1.6.0_07 I started jEdit like this
>
> jedit -nosettings
>
> I disable caret blinking
> And in the build.xml of jEdit I click on the scrollbar to scroll down
> once and one time up
> I have this with FastRepaintManager
>
> 00:54:20 [AWT-EventQueue-0] [debug] TextAreaPainter: repainting 3
> lines took 17664/239520/22906 ns
>
>
> And this without
>
> 00:55:14 [AWT-EventQueue-0] [debug] TextAreaPainter: repainting 25
> lines took 1833/1386457 ns
>
>
> I also tried to go to the end of the buffer here are the results
> 01:03:49 [AWT-EventQueue-0] [debug] TextAreaPainter: repainting 25
> lines took 6850/2007007/31756 ns
> 01:04:59 [AWT-EventQueue-0] [debug] TextAreaPainter: repainting 25
> lines took 1813/1555419 ns
>
>
> So when only scrolling 3 lines it is much faster with the
> FastRepaintManager, but little slower when repainting all.
> But I think in most case a few lines are repainted so the
> FastRepaintManager seems useful to me
>
>
>  I use a E6600 (2.4 Ghz), maybe the difference is on the processor
> speed, change something ...
> I think it should remain as an option until we find why I have this
> big difference with your test
>
> Matthieu
>