From: SourceForge.net <no...@so...> - 2008-05-27 03:04:10
|
Bugs item #1670241, was opened at 2007-02-27 10:40 Message generated for change (Comment added) made by ezust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100588&aid=1670241&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: search and replace Group: normal bug >Status: Pending >Resolution: Works For Me Priority: 5 Private: No Submitted By: daniel hahler (blueyed) Assigned to: Alan Ezust (ezust) Summary: "Synchronize" in Search dialog should use "last extension" Initial Comment: When a file like foo.class.php is opened and you click "Synchronize" in the "Search and Replace" dialog, the file glob pattern gets set to "*.class.php". IMHO this should be rather "*.php" (only the "last" extension. The Synchronize button uses MiscUtilities.getFileExtension and this returns the part of the filename, after the first dot. This is meant to handle e.g. ".tar.gz" as an extension - so it should not get changed in MiscUtilities. Instead the "Synchronize" action should use a custom method IMHO. ---------------------------------------------------------------------- >Comment By: Alan Ezust (ezust) Date: 2008-05-26 20:04 Message: Logged In: YES user_id=935841 Originator: NO I am trying to reproduce this bug and it does no longer reproduce. I wonder if someone changed the behavior of the MiscUtilities.getFileExtension(), MiscUtilities.getFileExtension("foo.tar.gz") returns ".gz" MiscUtilities.getFileExtension("foo.class.php") return ".php" ---------------------------------------------------------------------- Comment By: daniel hahler (blueyed) Date: 2007-07-31 14:36 Message: Logged In: YES user_id=663176 Originator: YES Yes, I think this makes sense: have a special case for known file types which have "double extensions". Are there others like .gz and .bz2? What about "file.php.gz"? Should getFileExtension return "php.gz" for this one? ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-07-31 14:05 Message: Logged In: YES user_id=935841 Originator: NO perhaps miscUtilities.getFileExtension should have a special case for any .gz or .bz2 files ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100588&aid=1670241&group_id=588 |