Menu
▾
▴
[ jEdit-devel ] [ jedit-Plugin Bugs-1934589 ] BufferList: click on file does not alway load buffer
|
From: SourceForge.net <no...@so...> - 2008-04-19 17:46:11
|
Plugin Bugs item #1934589, was opened at 2008-04-04 15:32 Message generated for change (Comment added) made by goebbe You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1934589&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: goebbe (goebbe) Assigned to: Nobody/Anonymous (nobody) Summary: BufferList: click on file does not alway load buffer Initial Comment: Using Jedit 4.3pre13 with Java 1.6.0_05 on WinXP SP2 I suffer from the following bug in the BufferList 1.1 -Plugin: Clicking on the the buffer name of the open buffers in the buffer list does not always "activate/load" the buffer. By activating the buffer I mean: make the contents of the buffer visible in the main text-window and showing the buffer name in the buffer-list in bold face. To reproduce this bug do the following: 1. Open Jedit 2. Install the latest Buffer-list plugin and dock the plugin window at the left or right. 3. Create several new files (e.g. by C+n ) 4. Use the Bufferlist to activate/load the files one after the other into the main text area 5. Observation: At every 4-8th click the buffer is not activated/loaded, instead the buffer name has a blue background without the text not being in bold face and no change in the main text area. The usability of the BufferList plugin is obviously reduced since a click (or a double click to close a file) on the buffer name does not result in a predictable behavior. Additional comment: This bug was already present before 4.3pre13. Please let me know if I can provide additional information. Keep up the good work! Jedit is a fantastic Text-Editor! ---------------------------------------------------------------------- >Comment By: goebbe (goebbe) Date: 2008-04-19 17:46 Message: Logged In: YES user_id=1050273 Originator: YES Since this bug has been marked as "fixed" and "closed" - are there any plans to submit a fixed version (upgrade) the BufferList-plugin? Or to put it different: Shouldn't this bug be marked "open" / "fix available", just to make sure that this bug will not be forgotten, before the new version of the plugin is released? ---------------------------------------------------------------------- Comment By: goebbe (goebbe) Date: 2008-04-13 16:45 Message: Logged In: YES user_id=1050273 Originator: YES Thanks a lot halyavin! I downloaded the latest version with fixed one-click and double-click behaviour and played around with it. Both problems are fixed and I couldn't find negative side effects. With the fixes, the usability of BufferList plugin has improved quite a bit! ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2008-04-13 16:33 Message: Logged In: YES user_id=935841 Originator: NO I just imported the project into SVN. Halyavin, you have a choice. You can submit a tracker item with the patch as an attachment, or volunteer to become the new maintainer of bufferlist plugin and commit directly. Which would you prefer? ---------------------------------------------------------------------- Comment By: halyavin (halyavin) Date: 2008-04-12 07:29 Message: Logged In: YES user_id=1600924 Originator: NO Link to the diff file (generated by diff utility (because BufferList is not in SVN) I don't know where originated from - so it have to be applied by hand): http://www.humyo.com/F/1256425-132193015 . I would like to see it committed but I don't have commit rights. ---------------------------------------------------------------------- Comment By: halyavin (halyavin) Date: 2008-04-12 07:10 Message: Logged In: YES user_id=1600924 Originator: NO Java do know about 4-clicks. So 4-click can't be factorized as 2 consecutive 2-clicks. But 2n-clicks can be mapped to 2-clicks though. (I replaced in MouseHandler.mouseClicked line if (e.getClickCount() > 2) with if (e.getClickCount() > 2 && e.getClickCount() % 2 != 0) and line if (e.getClickCount() == 2 && jEdit.getBooleanProperty("bufferlist.closeFilesOnDoubleClick", true)) { with if (e.getClickCount() >= 2 && jEdit.getBooleanProperty("bufferlist.closeFilesOnDoubleClick", true)) { ) I uploaded new version here: http://www.humyo.com/F/1256425-132191091. ---------------------------------------------------------------------- Comment By: goebbe (goebbe) Date: 2008-04-11 16:51 Message: Logged In: YES user_id=1050273 Originator: YES O.k. I used the new BufferList-plugin extensively during the last hours and didn't find any showstopper. Thanks a lot for fixing the one-click behavior. Your effort is highly appreciated! The issue with the large delay in the case of a double click is most likely a different issue - should I open a new bug report for that? Or is this just a minor bug/inconvenience that can be fixed easily? Just in case that there will be an update to the BufferList-plugin: The plugin GNUregexp is a dependency that is required for BufferList since Jedit4.3pre13. Perhaps one could add this requirement for the new package? ---------------------------------------------------------------------- Comment By: goebbe (goebbe) Date: 2008-04-11 12:00 Message: Logged In: YES user_id=1050273 Originator: YES Thanks a lot for providing the package. I will test the new BufferList plugin this afternoon. My first impression is that switching Buffer with a single click works well now. However the when I try to close a series of files (via a double click on the Buffer-name in the Buffer list) there is a remarkable delay. Because of this delay clicking four times does not always close two buffers. To reproduce: 1. open a list of files. 2. put the mouse pointer on the position of the first buffer and double click. (the first buffer should be closed). 3. double click twice (4x) on the same position (this should close the following two buffers). One can see that there is a big delay before the second double click can be applied successfully. Thanks a lot for the effort! I am gonna report my experience with the new plugin in some hours. ---------------------------------------------------------------------- Comment By: halyavin (halyavin) Date: 2008-04-11 10:19 Message: Logged In: YES user_id=1600924 Originator: NO You can test my fix - http://www.humyo.com/F/1256425-132030669 . Place BufferList.jar file (it is worth to backup original file) in your {jedit.install.dir}/jars directory (or {home}/.jedit/jars directory - depends on your settings). In this fix the buffer changes when you use ctrl+click or shift+click for multiple selection. I don't understand how multiple selection supposed to work with buffer switching though. May be this is how it should behave. ---------------------------------------------------------------------- Comment By: goebbe (goebbe) Date: 2008-04-11 07:34 Message: Logged In: YES user_id=1050273 Originator: YES The way the bug can reproduced reminds me another bug that I reported some months ago: [ 1741783 ] regression: loosing selection when activating context menu http://sourceforge.net/tracker/?func=detail&aid=1741783&group_id=588&atid=100588 This other bug is similar in the sense that it is caused by moving the mouse during a (right) click of the mouse leads to a loss of the selected text (which can be considered as a regression compared to Jedit 4.2.). Well take this comment with a grain of salt - I am not a java-developer by any means. By the way I just checked if the Jedit File Browser is also affected from this bug (don't know to which extend they share code). The File browser does not suffer from this bug. ---------------------------------------------------------------------- Comment By: halyavin (halyavin) Date: 2008-04-11 05:29 Message: Logged In: YES user_id=1600924 Originator: NO We can move buffer-change logic to tree selection listener: //add after "tree.addKeyListener(new KeyHandler());" line in BufferList constructor. tree.addTreeSelectionListener(new TreeSelectionListener(){ public void valueChanged(TreeSelectionEvent e) { if (e.getNewLeadSelectionPath()==null) { return; } BufferListTreeNode node = (BufferListTreeNode) e.getNewLeadSelectionPath().getLastPathComponent(); Object obj = node.getUserObject(); if (obj instanceof String) return; Buffer buffer = (Buffer) obj; BufferList.this.view.goToBuffer(buffer); }}); It may introduce new problems (what happens with multiple selection and selection of non-leaf elements?) - I have not much experience with JTree and the BufferList plugin. ---------------------------------------------------------------------- Comment By: Steve Jakob (sjakob) Date: 2008-04-10 18:35 Message: Logged In: YES user_id=17432 Originator: NO Interesting. You're right. Any movement of the mouse while clicking must get interpreted as a drag and not a click. ---------------------------------------------------------------------- Comment By: halyavin (halyavin) Date: 2008-04-10 17:44 Message: Logged In: YES user_id=1600924 Originator: NO I found 100% way to reproduce the bug: press mouse button at non-selected file, drag it a little, release mouse button. So the BufferList plugin works only if you click without any dragging. ---------------------------------------------------------------------- Comment By: goebbe (goebbe) Date: 2008-04-10 08:09 Message: Logged In: YES user_id=1050273 Originator: YES I just found bug #1639468 which seems to be related. If this is indeed the same bug, than BufferList seems to suffer from it for quite some time. :-/ ---------------------------------------------------------------------- Comment By: goebbe (goebbe) Date: 2008-04-09 13:24 Message: Logged In: YES user_id=1050273 Originator: YES This bug is also present on Linux (ubuntu hardy): Jedit4.3pre13, Sun java 1.6.0_05 When changing/loading/activating open files via the BufferList then sometimes a single click is sufficient and sometimes not. To reproduce just open some files and toggle between the files (by using the mouse). On my Linux system it misses to load/activate the open file in approximately 1 out of 6 cases. Anybody else who can reproduce? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1934589&group_id=588 |