Menu
▾
▴
[ jEdit-devel ] [ jedit-Plugin Bugs-1897798 ] Moving diff does't work in Jdiff1.8-window
|
From: SourceForge.net <no...@so...> - 2008-02-21 09:08:39
|
Plugin Bugs item #1897798, was opened at 2008-02-20 12:37 Message generated for change (Comment added) made by goebbe You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1897798&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: goebbe (goebbe) Assigned to: Nobody/Anonymous (nobody) Summary: Moving diff does't work in Jdiff1.8-window Initial Comment: When I tested the proposed 1.8.0 Jdiff-plugin I realised that the "move diff to the left" and "move diff to the right"-buttons in the Jdiff-Window do not work any more. Only the small black triangles in the main editor field do their job correctly. To reproduce: 1. Make a dual diff 2. move the cursor to a line with different contents 3. try to move the diff by clicking on the corresponding icons in the Jdiff-window (in my case docked on the bottom). Nothing happens. All other Buttons in the Jdiff-window work as expected. Workaround: Use the small triangles in the main text field to move the diffs. I also suggest to change the tooltip-text from: "move diff to the right" to something like: "move diff-block to the right" (equivalently for left) Since (at least in Jdiff 1.7.0) not only the line that is shown in the Jdiff-window is moved but the whole corresponding block of text that is different. The current text can be confusing since the Jdiff-Window only shows the diff for the current line! And "Move diff to ..." would usualy be interpreted as "Move the diff that is shown in the Jdiff-Window" (only one line) and this is not the case. All in all the changes between Jdiff 1.7 and the proposed Jdiff 1.8 are highly appreciated! ---------------------------------------------------------------------- >Comment By: goebbe (goebbe) Date: 2008-02-21 09:08 Message: Logged In: YES user_id=1050273 Originator: YES Thank a lot for fixing this issue. I tested the new jar and now everything seems to be perfect! ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2008-02-21 03:11 Message: Logged In: YES user_id=187628 Originator: NO Thanks, I'd noticed that too. Looks like I forgot to rewire the buttons when I did some refactoring. It's fixed in JDiff 1.9.0. I also changed the tooltip text. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1897798&group_id=588 |