Menu
▾
▴
[ jEdit-devel ] [ jedit-Patches-1755992 ] Consistent jEdit icon set from Tango Project
|
From: SourceForge.net <no...@so...> - 2007-09-14 03:08:49
|
Patches item #1755992, was opened at 2007-07-18 02:54 Message generated for change (Comment added) made by ezust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1755992&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: texteditor Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Seph M. Soliman (scarlac) Assigned to: Nobody/Anonymous (nobody) Summary: Consistent jEdit icon set from Tango Project Initial Comment: Hi, I've been working on giving jedit a consistent l&f. Since users have freedom over component l&f through swing the only thing jedit needs is to adhere to styling guidelines and have a consistent icon set. jEdit already has an ad-hoc icon set, but alas, not very consistent in dimensions or in naming, making it difficult to skin jedit without making changes to the code. I propose an implementation of the Tango Icon Library as specified on: http://tango.freedesktop.org/Tango_Icon_Library I will of course supply the necessary patches and have already implemented most of the icons. I've taking a few screenshots of my local working copy so you can have a taste: http://www.begynd.com/tangofied_jedit/ The current status is that i've gotten very far with the patch. I'm still making small modifications to the code, to factor out hardcoded icon names into the jedit_gui.prop file, for greater flexibility. I'm online on IRC as "scarlac". If you have any suggestions or comments, please contact me. I'll continue to work on the patch if people want it, but if people dislike it, then I'll just stop. Regards, Seph M. Soliman www.mijav.dk ---------------------------------------------------------------------- >Comment By: Alan Ezust (ezust) Date: 2007-09-13 20:08 Message: Logged In: YES user_id=935841 Originator: NO I'm using the tangoified jedit patch now. I like the icons, and your changes, but reflecting on the comments of others, I'm thinking I should not accept it as is. What I would like to do is accept a patch and a plugin from you. First, the patch which contains the minimal changes to jEdit core to support your plugin, which can totally replace the core iconset with your own iconset. But now that I've applied it to my own copy, let's see if I get used to it and get annoyed when I must switch back. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-09-13 20:08 Message: Logged In: YES user_id=935841 Originator: NO I'm using the tangoified jedit patch now. I like the icons, and your changes, but reflecting on the comments of others, I'm thinking I should not accept it as is. What I would like to do is accept a patch and a plugin from you. First, the patch which contains the minimal changes to jEdit core to support your plugin, which can totally replace the core iconset with your own iconset. But now that I've applied it to my own copy, let's see if I get used to it and get annoyed when I must switch back. ---------------------------------------------------------------------- Comment By: Seph M. Soliman (scarlac) Date: 2007-08-23 12:56 Message: Logged In: YES user_id=831311 Originator: YES pong! I've been buried in work, but i can submit a current-state patch for you/people to test. I've made a patch of the current state of my work for you to review: http://www.begynd.com/tangofied_jedit/patch_and_images.zip The patch contains images and some changes to the historytextfield as well, to make the looks on the GTK feel nicer. There are however one current issue: Java has some issues with displaying icons in the regular menu on windows using native l&f. Depending on java version it will add too much margin in the menu or forget to use margin at all. I've been using the patch for a couple of weeks now, and i've come to really like many of the changes. In the beginning i would have agreed that they are very colorful, but after 1 hour you completely forget about it - even though I personally use a dark color scheme (as seen on the screenshots). To be frank, this patch contains a lot of work - and there is still some work to go, but it would *really* be helpful for me to get this patch accepted so I can get a fresh copy and work from there on :) I hope you understand, and I accept if it's too much to ask. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-08-23 11:51 Message: Logged In: YES user_id=935841 Originator: NO ping? There is no way I can ever test the patch or close this ticket until you submit an actual patch as an attachment to this tracker item. ---------------------------------------------------------------------- Comment By: Robert Schwenn (rschwenn) Date: 2007-08-01 13:32 Message: Logged In: YES user_id=1486645 Originator: NO Since it's possible to change basic Look & Feel in Global Options -> Appearance, I'd wish to be able to change icon sets there too. Aadditional it would be nice, if the matching dropdown, that may list the available icon sets, could list user added icon sets too. Of course this implements the wish to easily add other icon sets and/or extra icons for macros and actions to any icon sets ;-) For this reason the icons should propably not be stored inside jedit.jar? Regarding the fears about changes: Why don't deliver jEdit in the future with at least 3 icon sets: "classic" alias old, "tango gray", "tango color" ? ---------------------------------------------------------------------- Comment By: Shlomy Reinstein (shlomy) Date: 2007-08-01 05:01 Message: Logged In: YES user_id=1477607 Originator: NO That's great to hear. I actually missed an important point here that I'd like to make clear: It's not that I like the way the current icons look. Personally I think the current icons are quite bad, and I'd be very glad to replace them with more meaningful ones. My problem with the new icon set is related to the colors, that can attract the attention from the main purpose of editing. I think we both agree on these things. ---------------------------------------------------------------------- Comment By: Seph M. Soliman (scarlac) Date: 2007-08-01 04:42 Message: Logged In: YES user_id=831311 Originator: YES kpouer: You rightfully make the same point as daleanson - so the same answers apply. In general: People become familiar with something and are resistant to any change (same old story). shlomy: I can understand your concern, as I feel that icons shouldn't grab your attention but inform you of their function. I did some research on typical jedit users and they generally have the following statements to the question: "What's your opinion on the jedit icons?": * I've gotten used to them. * They are not pretty. * I'd rather they spend their time on improving the functionality All 3 statements clearly points to the fact that people are not so concerned about the GUI as long as it works (no surprise there). Bullet 1 and 2 also indicates that people are not happy with the current icons but with time they become used to them. Judging from my own experience, it took me long to get to know what the current icons do as opposed to the time it took to get used to the tango icons. I usually disable the toolbar, since I'd rather use the hotkeys and focus on the code. So to sum up: I am very much aware of the resistance to change and it is my firm belief tango will provide new users a considerable better first-hand experience than the current look do. Like always, they will have the complete freedom to change the icons should they choose to. ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2007-08-01 03:24 Message: Logged In: YES user_id=285591 Originator: NO Hi, that's nice, but since some developpers prefers the current l&f of jEdit, I don't think we can change the default icon set. But if some changes has to be made in the core to easily switch to another icon set I think it could be done and those icons could come with a plugin ---------------------------------------------------------------------- Comment By: Shlomy Reinstein (shlomy) Date: 2007-08-01 03:12 Message: Logged In: YES user_id=1477607 Originator: NO While these icons are very nice, one of the reasons I like jEdit is the way it currently looks - an icon set which is all grayscale, and buttons/tabs with light blue. This is the best setup for me, as I can easily focus on the code I'm editing without being attracted by colored buttons. So I hope that whatever patch you're creating, the users will be able to keep the old icon set if they wish to. Speaking of this, I wrote the CtagsSideKick plugin, which adds some colored icons to the SideKick window. These icons turned out not to attract my eyes while editing code (especially since they are very simple icons), but looking at the screenshots you provided I'm afraid the new icon set would. ---------------------------------------------------------------------- Comment By: Seph M. Soliman (scarlac) Date: 2007-08-01 02:14 Message: Logged In: YES user_id=831311 Originator: YES I've updated the webpage for this patch to reflect the current work: http://www.begynd.com/tangofied_jedit/ I've also released a build that you can download and test if you feel like exploring :-) Regards, Seph M. Soliman www.mijav.dk ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-07-30 20:03 Message: Logged In: YES user_id=935841 Originator: NO I like the icons. I'm curious to see the patch. ---------------------------------------------------------------------- Comment By: Seph M. Soliman (scarlac) Date: 2007-07-18 06:54 Message: Logged In: YES user_id=831311 Originator: YES Some of the changes in the patch moves hardcoded filenames to settings in jedit_gui.prop so icons can be changed easily. A sensible and simple directory structure for icons are also in the patch. I did however consider using the L&F plugin, but dismissed it since it impairs GUI performance. One of the main goals for this patch is to give jEdit a complete and professional look out-of-the-box by choosing a clean icon set. Some plugins such as the ProjectViewer plugin use icons from the current icon set. Plugins doing so will be "beautified" without need for refactoring. ---------------------------------------------------------------------- Comment By: Matthieu Casanova (kpouer) Date: 2007-07-18 06:31 Message: Logged In: YES user_id=285591 Originator: NO Maybe, but in the other hand, the actual jEdit look & feel is old and could also be replaced by a new one to look more modern ---------------------------------------------------------------------- Comment By: Dale Anson (daleanson) Date: 2007-07-18 06:22 Message: Logged In: YES user_id=187628 Originator: NO I like the icons. Would it make sense to add your icon set to the look and feel plugin, and let the user choose their preferred icon set from there? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1755992&group_id=588 |