From: SourceForge.net <no...@so...> - 2007-07-11 17:27:58
|
Patches item #1752044, was opened at 2007-07-11 08:51 Message generated for change (Comment added) made by ezust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1752044&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: Accepted Priority: 5 Private: No Submitted By: Kazutoshi Satoda (k_satoda) Assigned to: Nobody/Anonymous (nobody) Summary: API Proposal: CompletionPopup Initial Comment: I locally have class CompletionPopup which was extracted from CompleteWord and SideKickCompletionPopup. Of course this avoids code duplication. I think this can be a good way to provide uniformed look and feel through various implementations of word completion. I'll upload my working (maybe incomplete) patch to this tracker item, and wait acceptance (setting the Resolution as Accepted) by one or more of other developers. If I got it, I'll commit the change into the svn trunk. Any comments, reviews or advices are also welcome. ---------------------------------------------------------------------- >Comment By: Alan Ezust (ezust) Date: 2007-07-11 10:27 Message: Logged In: YES user_id=935841 Originator: NO ok, let's do this for pre11 then. ---------------------------------------------------------------------- Comment By: Marcelo Vanzin (vanza) Date: 2007-07-11 10:22 Message: Logged In: YES user_id=75113 Originator: NO Oh, don't get me wrong, I totally agree. I actually have no idea why 4.3pre10 hasn't been released yet. Let's do it already. ---------------------------------------------------------------------- Comment By: Kazutoshi Satoda (k_satoda) Date: 2007-07-11 10:20 Message: Logged In: YES user_id=1483238 Originator: YES Sorry. change of the Resolution in my previous comment was not intended. Reverted to Accepted. Hi Marcelo, this patch includes the fix for that issue. The class WindowFocusHandler in CompletionPopup does it. ---------------------------------------------------------------------- Comment By: Kazutoshi Satoda (k_satoda) Date: 2007-07-11 10:12 Message: Logged In: YES user_id=1483238 Originator: YES Thank you for your quick acceptance, but... I think 4.3pre10 already contains too much changes and became too late. I think it shouldn't be delayed anymore. Furthermore, this change has possibility to break something around daily use while having little user benefits. I would like that this change starts to be tested among developers in svn trunk just after 4.3pre10. ---------------------------------------------------------------------- Comment By: Marcelo Vanzin (vanza) Date: 2007-07-11 10:08 Message: Logged In: YES user_id=75113 Originator: NO +1, especially if this fixes the issue I see sometimes of two completion popups coming up, one above the other. :-) ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-07-11 09:37 Message: Logged In: YES user_id=935841 Originator: NO I like it, reduced redundant code is always nice, and now it will be easier to make uniform changes to completion popups. We should test it for a couple of days before releasing pre10 though, don't you agree? ---------------------------------------------------------------------- Comment By: Kazutoshi Satoda (k_satoda) Date: 2007-07-11 08:58 Message: Logged In: YES user_id=1483238 Originator: YES Here is another patch for SideKick which uses new CompletionPopup in the proposed patch. File Added: SideKick_with_CompletionPopup_in_core.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1752044&group_id=588 |