From: SourceForge.net <no...@so...> - 2007-07-08 13:11:43
|
Patches item #1733221, was opened at 2007-06-08 07:56 Message generated for change (Comment added) made by vampire0 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1733221&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Daniel Johnson (delvinj) Assigned to: Björn Kautler (vampire0) Summary: Use look&feel font for menu shortcuts Initial Comment: EnhancedMenuItem currently ignores the Look and Feel font for drawing menu item accelerators (shortcut keys). The font specified looks poor and clashes with the system look and feel. This patch makes EnhancedMenuItem respect the Look and Feel font. ---------------------------------------------------------------------- >Comment By: Björn Kautler (vampire0) Date: 2007-07-08 15:11 Message: Logged In: YES user_id=918212 Originator: NO The right is with the L&F font, the left with the jEdit defined font. So we will use the L&F font, ok. Btw. unfortunately I cannot test it on Mac OS X, because the Mac OS X I run has only Java 1.4 and I cannot update it for some reason, so I can build the dmg file what only needs 1.4 but not run jEdit as it needs 1.5. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-07-08 03:44 Message: Logged In: YES user_id=935841 Originator: NO oh wait. I see the two columns now. for some reason I had it zoomed wrong before. the right column looks slightly nicer than the left, I think. ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-07-08 03:26 Message: Logged In: YES user_id=935841 Originator: NO I do not have a strong opinion on this issue. As for comparison charts, what am I looking at? What is before and what is After re: this patch? ---------------------------------------------------------------------- Comment By: Björn Kautler (vampire0) Date: 2007-07-03 11:03 Message: Logged In: YES user_id=918212 Originator: NO File Added: code-comparison.png ---------------------------------------------------------------------- Comment By: Björn Kautler (vampire0) Date: 2007-07-03 11:03 Message: Logged In: YES user_id=918212 Originator: NO I'm not sure we should change this. For me it doesn't look like this code is a mistake, but wanted. Iirc delvinj you said in IRC that you think this was done by accident. I'm not sure what the intention was initially, maybe that the characters consume the same space and thus the shortcuts are aligned, sort of. I took a few comparing screenshots for the L&Fs on my box and assembeld them to a comparison chart. Alan, what do you think? File Added: code-comparison.png ---------------------------------------------------------------------- Comment By: Alan Ezust (ezust) Date: 2007-07-02 00:29 Message: Logged In: YES user_id=935841 Originator: NO Vampire0, can you test this on a Mac? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300588&aid=1733221&group_id=588 |