From: SourceForge.net <no...@so...> - 2007-06-28 15:54:16
|
Plugin Bugs item #1744627, was opened at 2007-06-28 00:08 Message generated for change (Comment added) made by ezust You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1744627&group_id=588 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Shlomy Reinstein (shlomy) Assigned to: Shlomy Reinstein (shlomy) Summary: SideKick can't determine mode of current buffer Initial Comment: Whenever the user opens a file using File->Open or by double clicking it in the File System Browser, SideKick fails to find the parser for the file and logs the following message: SideKick: can't determine mode of current buffer Diving into the code, I saw two things that need to be fixed: 1. SideKick tries to find the parser in response to the EditPaneUpdate.BUFFER_CHANGED message, which arrives before the buffer is loaded. Since the buffer is not yet loaded, jEdit hasn't yet determined its mode, this is the reason for the above log message. This is NOT the reason why SideKick fails to parse the newly opened buffer, but it's a redundant message that is logged to the activity log and should be avoided. 2. Once the buffer is loaded, SideKick gets the BufferUpdate.LOADED message, and ignores it if the view associated with the message is different from that of SideKick. For some reason, this message always comes with a "null" view, so jEdit always ignores the message (since the SideKick view is not null). I think this is a bug in jEdit itself, but as a quick workaround can be to add the "bmsg.getView() != null" to the view comparison test. ---------------------------------------------------------------------- >Comment By: Alan Ezust (ezust) Date: 2007-06-28 08:54 Message: Logged In: YES user_id=935841 Originator: NO For #2, I did something a little better, now sidekick assumes that if the view is null, we compare the sidekick view to jedit's activeview. Committed to 9870 ---------------------------------------------------------------------- Comment By: Shlomy Reinstein (shlomy) Date: 2007-06-28 01:28 Message: Logged In: YES user_id=1477607 Originator: YES Fixed bullet number 1 in SVN rev 9867. ---------------------------------------------------------------------- Comment By: Shlomy Reinstein (shlomy) Date: 2007-06-28 00:56 Message: Logged In: YES user_id=1477607 Originator: YES Sorry, bullet number 2 above has already been fixed by Alan in SVN rev 8915, which belongs to the development version of jEdit (4.3pre10). I work with jEdit 4.3pre9, so I didn't have this fix. So, only bullet number 1 remains - a redundant "Can't determine mode" message by SideKick. SideKick now logs the redundant message but it does find the correct parser for the opened files and works fine. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=565475&aid=1744627&group_id=588 |