[ jEdit-devel ] [ jedit-Bugs-1716134 ] PHP Mode - Problem with function parentheses

[SourceForge.net <no...@so...>]

Bugs item #1716134, was opened at 2007-05-09 23:13
Message generated for change (Comment added) made by lemon_juice
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=1716134&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: text area and syntax packages
Group: normal bug
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Alexander Cicovic (acicovic)
Assigned to: daniel hahler (blueyed)
Summary: PHP Mode - Problem with function parentheses

Initial Comment:
Hi there.  I am using 4.3pre9.  I've downloaded the latest PHP mode (at least I think so) from the SVN in order to remedy the double quote escape character issue.

However, now I see that function parentheses are not colored correctly.

test_function()
{
    echo('test');
}

In the above example, the function declaration's closing parentheses does not seem to be colored correctly, nor it shows its opening tag when you select it.

----------------------------------------------------------------------

Comment By: Lemon Juice (lemon_juice)
Date: 2007-05-13 01:26

Message:
Logged In: YES 
user_id=1630383
Originator: NO

Like acicovic I also had the problem that everything that had parentheses
to it was of the stadard FUNCTION color. If anyone is interested I have
found a temporary workaround for this problem by trying to hack php.xml - I
found the line which contained <IMPORT DELEGATE="PHP_FUNCS"/> which was
line 395 in this case and I simply commented out this tag - this had the
effect of turning off generic colouring of functions, which magically
brought the correct colouring of built-in php function as well as
statements like if(), switch(), etc. So now my custom functions do not have
their proper colour, but some other (perhaps LITERAL1 ?) colour in bold -
but this is not much of a problem because at least the 3 different items
(custom functions, built-in functions and language statements) have
separate colours. However, method names like in $obj->method() are stilled
coloured properly. I think this makes things a bit better but still we will
have to wait for the proper fix by someone more knowledgeable.

----------------------------------------------------------------------

Comment By: Alexander Cicovic (acicovic)
Date: 2007-05-11 11:54

Message:
Logged In: YES 
user_id=1230519
Originator: YES

Hi there,

I tried the file and it fixes the issue.  Apart from applying the generic
function color to everything which has parentheses to it (even if, switch
statements) it seems to work pretty well.

----------------------------------------------------------------------

Comment By: daniel hahler (blueyed)
Date: 2007-05-11 00:11

Message:
Logged In: YES 
user_id=663176
Originator: NO

Could you please try the php.xml file from
http://codeprobe.de/pub/jedit/php.xml ?

This should include/provide a lot of improvements to the current php.xml
file, except that included functions now do not get highlighted separately
anymore - e.g. foo() is the same as strcmp().

I will look into fixing this, but it would be great if you could provide
if this php.xml file fixes your issue.

----------------------------------------------------------------------

Comment By: Alexander Cicovic (acicovic)
Date: 2007-05-09 23:16

Message:
Logged In: YES 
user_id=1230519
Originator: YES

Besides forgetting the function keyword in the function declaration, I now
see that this seems to be happening to all closing parentheses...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=1716134&group_id=588