Re: [ jEdit-devel ] Fixing #define in C mode?

[Vampire <Vam...@gm...>]

Hi,

I didn't look too close to it yet, but one thing falls into my eye 
immediately. About the Action Hints in Parser Rule class. I think you 
shouldn't change the values of public static final fields because they 
are part of the public API. There could be places where the actual 
values are stored instead of the variablenames. E. g. in already 
compiled code where the compiler had replaced the variable by the actual 
value because the value cannot change as it is public static final. This 
will not lead to a RuntimeException immediately, but only manifest 
itself very shiny maybe.

Regards,
Vampire

PS: If it gets applied, all distributed ModeFiles have to be scanned and 
fixed to not use the deprecated attribute

Marcelo Vanzin wrote:

> So I played with the syntax code a little bit and came up with a
> solution. I'm attaching two diffs:
>
> - The first one is the jEdit patch. It removes "EXCLUDE_MATCH" and
> replaces it with a "MATCH_TYPE" attribute, that defines how the
> matching substring should be highlighted. So now there's more fine
> grained control of that.
>
> This allows, for example, the use of a MARK_PREVIOUS tag to highlight
> a function call, and still highlight ( as an operator, keeping bracket
> matching happy.
>
> - The second patch is a small modification to Kazutoshi's c.xml to
> highlight function calls.
>
> So, let me know what you guys think, and if you find any problems with
> this code.
>
> On 2/19/07, Marcelo Vanzin <va...@us...> wrote:
>
>> Hi Kazutoshi,
>>
>> On 2/15/07, Kazutoshi Satoda <k_s...@f2...> wrote:
>> > I have a custom-c mode which has been modified a lot from the original
>> > c mode. I made this to use it for both C and C++ file.
>>
>> Overall I like you mode a lot better than the original! It doesn't
>> have the problems I don't like in the current C-mode, but it does have
>> one problem: it doesn't highlight function calls.
>
>
>------------------------------------------------------------------------
>
>-------------------------------------------------------------------------
>Take Surveys. Earn Cash. Influence the Future of IT
>Join SourceForge.net's Techsay panel and you'll get the chance to share your
>opinions on IT & business topics through brief surveys-and earn cash
>http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>