Re: [ jEdit-users ] Re: [ jEdit-devel ] Patch for Bug 1303461 Exception when removing a node from hypersearch results

[Matthieu C. <cho...@gm...>]

Hi, a simple fix would be to replace in method
HyperSearchOperationNode.removeNodeFromCache line 114
operNode.resultNodes.remove(node);
by
if (operNode.resultNodes !=3D null)
  operNode.resultNodes.remove(node);

since if the nodes aren't cached there is no need to remove the node from
cache isn't it ?

Matthieu

2005/12/18, Slava Pestov <sl...@je...>:
>
> Hi Peter,
>
> Its better to fix the root cause of a problem rather than work around it.
>
> Slava
>
> Peter Cox wrote:
> > This bug was caused by a accessing the instance variable resultNodes
> > which had not been initialised.
> >
> > The class accesses this variable in multiple places with checks for
> > null. So, possible solutions:
> >
> > (1) place null checks around variable access
> > (2) Lazy init the variable
> > (3) init in constructor
> >
> > I've done the third option which may unnecessarily increase memory
> > consumption. But without thoroughly understanding the usage of the
> > instance variable, it's the easiest path with least code change.
> >
> > unified diff attached...
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log
> files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_id=3D7637&alloc_id=3D16865&op=3Dclick
> --
> -----------------------------------------------
> jEdit Users' List
> jEd...@li...
> https://lists.sourceforge.net/lists/listinfo/jedit-users
>