[ jEdit-devel ] [ jedit-Bugs-1215041 ] Macro: Hex_Convert | weird for-loop and not usable function

[SourceForge.net <no...@so...>]

Bugs item #1215041, was opened at 2005-06-04 22:23
Message generated for change (Comment added) made by orutherfurd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=1215041&group_id=588

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: macros
Group: normal bug
>Status: Closed
Resolution: None
Priority: 5
Submitted By: Vampire (vampire0)
>Assigned to: Ollie Rutherfurd (orutherfurd)
Summary: Macro: Hex_Convert | weird for-loop and not usable function

Initial Comment:
In the Hex Convert Macro v 1.3, delivered with jEdit 4.2 
final, there is a very weird for-loop:

for (int i = 0; i < string; k++)
{
....foo.append("0x" + byteToHex(string[k]));

shouldn't that be

for (int i = 0; i < length; i++)
{
....foo.append("0x" + byteToHex(string[i]));

?
((string -> length) && 2*(k -> i))
And maybe a Space between the Hexvalues, not a 
comma. :-)

And second thing, the stringToByte is not accessible 
how the macro is. It is there, but only byteToHex is 
invoked on Macro-Execution.
And wouldn't it be nice if u could input more than one 
byte, e. g. separated by spaces in the 
byteToHex-Function? :-)

Greetz,
Vampire


----------------------------------------------------------------------

>Comment By: Ollie Rutherfurd (orutherfurd)
Date: 2005-06-08 17:38

Message:
Logged In: YES 
user_id=265596

Fixed.  Thanks for patch.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100588&aid=1215041&group_id=588