[ jEdit-devel ] [ jedit-Bugs-468086 ] Files not being saved when using FTP

[<no...@so...>]

Bugs item #468086, was opened at 2001-10-04 14:54
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=100588&aid=468086&group_id=588

Category: virtual file systems
Group: severe bug
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Chad Skeeters (goobsoft)
Assigned to: Nobody/Anonymous (nobody)
Summary: Files not being saved when using FTP

Initial Comment:
Sun jdk1.3.1
Windows2k
jEdit 3.2.2 
FTP-0.3

Since the ftp lists RENAME_CAP in getCapabilities, 
(according to BufferIORequest.java line 514) is saved 
as <path>#<filename>#save# and then renamed to 
<path><filename>.

The problem is that Microsoft FTP servers to not allow 
renaming to overwrite files even when write 
permissions are enabled.  See 
http://support.microsoft.com/support/kb/articles/Q161/0
/67.ASP

So what happens is the file is uploaded as 
<path>#<filename>#save# is uploaded then renaming 
results in a 550 Access Denied.  That's fine except 
that BufferIORequest.java line 538 : 

vfs._rename(session,savePath,path,view);

isn't checking to see that the return value is true.

Thanks to the fact that this project is open source 
and written in java I have modified mine to say:

        if((vfs.getCapabilities() & VFS.RENAME_CAP) != 
0)
          if (!vfs._rename(session,savePath,path,view))
            throw new IOException("An error occured 
while renameing the file");

so at least I know if there is a renameing error and 
the file didn't save.

I also removed the RENAME_CAP from FtpVFS.java line 71 
so ftp will work with microsoft's FTP servers.

As a side note I'd like to thank everyone working on 
this project and say that this is the best editor I've 
ever seen!  The fact that it's free makes it even 
better.

Chad Skeeters
goo...@go...

----------------------------------------------------------------------

>Comment By: Slava Pestov (spestov)
Date: 2001-10-09 21:46

Message:
Logged In: YES 
user_id=2280

will be fixed in next release of FTP plugin.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=100588&aid=468086&group_id=588