|
From: <dmo...@gm...> - 2001-08-25 13:47:40
|
Hello Slava, On Monday, August 20, 2001, 10:36:00 AM, you wrote: >> PS: Should we resolve EditBus, and move the >> ErrorList/InfoViewer/JIndex parts to their corresponding plugins=3F Now >> that Console directly requires ErrorList (and therefore, JCompiler), >> EditBus is quite superfluous. It's a good opportunity right now >> together with other the 3.0 changes. > Feel free to move the JIndex and InfoViewer parts to those plugins; > I will then remove the messages from the EditBus plugin. I'll do it for the ShowTokenInfo message necessary for JIndex. In fact, if nobody objects, I'll remove it or make it private in the JIndex implementation. Had any other plugin ever make use of it=3F I think not. Regarding the other message type, ViewURL, see below. > The issue of moving the rest to the ErrorList plugin is a bit tricky, > mainly because most plugins specify an explicit dependency for the > EditBus plugin, and if not installed, they will break, even if the > actual classes themselves are present. > I'm not sure if it's worth breaking that many plugins just for code > cleanness. You're right. I've done some thinking about the InfoViewer/JIndex issue, which I am still not happy with: What if we do it the other way round=3F!=3F We extend EditBus to maintain a list of "URL viewers", just like the list of ErrorSources. On startup, EditBus would register 4 viewers: - the jEdit HelpViewer - a process launcher for Netscape (with -reuse option) - a process launcher for IE (if on Windows) (Maybe John could write a OLE/COM/whatever native invoker for this...=3F!=3F John, what do you think=3F) - a generic process launcher with an arbitrary command line. InfoViewer would register itself on this list on, too. EditBus gets an option pane to choose among the list of URL viewers. When an ViewURL message is put onto EditBus, it is send to the chosen viewer. Advantage: users of JIndex can view URL's with their favorite browser without the need to install InfoViewer. Right now, they are forced to install InfoViewer, even if they don't use the browser component. Another advantage is that they now can use the jEdit HelpViewer, so that they don't need to install _any_ other browser! Dirk. |