[ jEdit-devel ] AntFarm comments

[Slava P. <sl...@je...>]

Hi,

I'm not sure who's the AntFarm maintainer. Todd? Anyway, from quickly
looking at the source, I have three suggestions:

- define a plugin.<plugin class name>.jars property:

  plugin.AntFarmPlugin.jars=jaxp.jar crimson.jar

  This ensures that these JAR files are deleted along with the plugin
  when it is being removed with the plugin manager.

- in actions.xml, you shouldn't use a stored AntFarm instance, because
  if the user opens multiple views, commands will only go to one of
  the AntFarm instances.

  Instead, remove the code to remember the AntFarm instance, and change
  actions.xml to do the following:

  wm = view.getDockableWindowManager();
  wm.addDockableWindow("antfarm");
  antfarm = wm.getDockableWindow("antfarm");
  antfarm.<foo>();

  The addDockableWindow() call opens it if not already open.

- In my opinion, all human readable strings, not just menu item labels
  and such, should be loaded from the properties. Note that the jEdit
  core follows this convention. I've given up trying to remind developers
  to do this though, because everyone except for me seems to like
  hard-coding UI text in the source.

Slava