#4067 Erroneous Dialog - Opening Backup File

[John Potelle]

jEdit 5.5.0 under JAVA SE 1.8.0_171 under Windows 10 Pro
Every file I open now pops up the "Opening Backup File" dialog saying "the file ... is likely a jEdit backup file". This never happened before v5.5.0. What is the criteria for determining when this dialog should appear?

[John Potelle]

Backup settings

[g]

This is a bug in MiscUtilities:isBackup

If properties:backup.suffix is a null string ("") then it will always return true.

[John Potelle]

If the backup prefix and suffix are both null and a backup path is not null, perhaps isBackup should check only the path of the file being opened...

[Dale Anson]

This is fixed, see also bug # 4069.

A side note -- the "isBackup" method can not check if the file is in the backup directory (if any) since it is only given the bare filename as a string to work with, not the path for the file.