#333 More patches from my fork

[Mercury233]

1. Add CIrrDeviceMacOSX::setWindowSize
2. Fix CIrrDeviceMacOSX::restoreWindow and implement CIrrDeviceMacOSX::maximizeWindow
   Make restoreWindow correctly restore the window from the zoomed (similar to Windows maximization) state.
3. Update macOS fullscreen handling
   macOS has two fullscreen modes: the traditional exclusive fullscreen mode, and the borderless fullscreen mode introduced in 10.7. Fullscreen entered through CreationParams.Fullscreen is always the former, while fullscreen entered by clicking the green title-bar button is the latter. In the former mode, the user cannot switch back to windowed mode directly, while in the latter mode they can.
   Methods such as restoreWindow should not have any effect in fullscreen mode; otherwise, the window may shrink without actually leaving fullscreen.
4. Remove old Burning Video files from project files
   Deleted in [r6752].
5. Replace non-ASCII hyphens with ASCII minus signs
6. Fix CIrrDeviceMacOSX::Display initialization
   Display is a CGDirectDisplayID, which is a UInt32.
7. Fix the missing type cast for CIrrDelegateOSX
8. Fix a typo in CIrrDeviceMacOSX::initKeycodes
9. Use snprintf_irr in CProfiler
10. Fix missing GL constants on macOS

[Michael Zeilfelder]

Thanks for the patches! I've applied the first 9. The last is a bit confusing - if GL_VERSION_3_2 is not defined then those defines should not be used (so also should not be missing anywhere). And when you have GL_VERSION_3_2 they should already exist. Adding them despite not having GL_VERSION_3_2 sounds wrong. Does Irrlicht use them somewhere and misses the GL_VERSION_3_2 check maybe?

[Mercury233]

I haven’t investigated it in depth. The compilation error on macOS is:

irrlicht/source/Irrlicht/COpenGLCoreTexture.h:189:23: error: use of undeclared identifier 'GL_TEXTURE_2D_MULTISAMPLE'

and the same macro in COpenGLCoreCacheHandler.h.

(_IRR_OPENGL_USE_EXTPOINTER_ is off as default.)

[Michael Zeilfelder]

Thanks, I indeed forgot to check version in a few places for that one. I hope [r6823] fixes all those

[Mercury233]

https://github.com/mercury233/irrlicht/commit/d6be544411e29840feeb488eb7dd4a26f57ea18d
https://github.com/mercury233/irrlicht/commit/41d4457af2412a85e900f2127919ed4de3d98a5d

Those files need to be fixed too.

[Michael Zeilfelder]

Thank you, I should have seen those.