Menu
▾
▴
1 Attachments
#456 [PATCH] Remove CFLAGS uses
I have a report in Debian here complaining about source/Irrlicht/Makefile overriding forcibly CFLAGS, which means hardening flags don't get passed on.
The original reporter set the severity as serious, someone stepped in and decided it could be minor, because there's no C code to compile with wrong flags.
I propose to just remove the use of CFLAGS.
Removing sounds bad (release would no longer be an optimized build which is not so good for a 3d engine). svn trunk already rewrote the Makefile a lot, thought it did at a bunch of new CFLAGS.
Maybe there is no problem replacing the := by += so you can pass more flags and our flags are still set. I did a quick test right now with svn trunk on Linux which seemed to have no problem with this. Likely also fine reworking the 1.8 Makefile in that way. Still have to try on MinGW.
Would that solve it for you?
[r6267] fixed it (I hope) for 1.8 branch.
Related
Commit: [r6267]
Perfect, thanks!