[Gramps-devel] patch for bug 1011388

[Jim S. <ji...@ji...>]

Hi

Find attached a patch for bug 1011388: "People having a burial date but
no death date count as livin"

I've added to function probably_alive(self,db) in RelLib.py -- I am
testing for the presence of events 'Cause Of Death', 'Burial' and
'Cremation', and if any of them are found, I return 0 (the person is
dead). 

I do this test after the existing test for the death-event handle, and
before the more complex 'too old' test (based off of the birth date).

I've tested it, and it seems to work ok for me -- I believe it will work
as intended for any caller of that function, but I do not entirely know
every condition under which that function will be called. 

Maybe someone who knows the code better (and the language!) can advise
if anything I've done will cause a problem?

Also up for review/negotiation is whether we should be checking for the
'Cause Of Death' event here -- can it exist on it's own? ...or can it
only accompany the 'death' event? If the latter is the case, then we can
safely remove it from the test -- although having it there is fairly
safe, covers all future options and shouldn't impact performance in any
way.

------

And 'Hi' to everyone here... I think gramps is a fantastic piece of
software!!!

I'd like to contribute some more bug patches and enhancements once I get
a little more organised with my 'spare-time' development ...I've only
just started learning python (like a few days ago -- because of wanting
to contribute to gramps, and also it's been on my languages-to-learn
list for a while) and I have only been working with linux/freebsd for 6
months or so.

I don't even have a decent development enviroment set up yet. :(


So much to do, and so much to learn!!!

Regards and best wishes,
Jim
-- 

---------------------------
        Jim Smart

      IT consultancy
   software engineering
  development & services

   e: ji...@ji...
   t: +44(0)1423 505207
---------------------------