[Gramps-devel] Review media scaling and dialogue [was proposed patch (media manager)]

[jerome <rom...@ya...>]

Could be linked/associated with #8419 ?

Where a signal issue has been fixed, but a "dialogue/size" issue remains.

The proposed work around, on MediaRef dialog, fixed it

self.scale = scale_to_fit(self.pixbuf.get_width(),
                                       self.pixbuf.get_height(),
-                                      viewport_size.width,
-                                      viewport_size.height)
+                                      viewport_size.width -6,
+                                      viewport_size.height -6)

but the solution should be somewhere else.
Maybe on window management?

I know that Media Manager does not use this code,
just wondering if there is not something around Window
management for embedded stuff on editors too?

https://gramps-project.org/bugs/view.php?id=8429


Jérôme


--------------------------------------------
En date de : Sam 14.1.17, Paul Franklin <pf....@gm...> a écrit :

 Objet: [Gramps-devel] proposed patch (media manager)
 À: gra...@li...
 Date: Samedi 14 janvier 2017, 19h51
 
 I'm wondering whether anybody is
 interested in testing or
 reviewing another proposed patch?
 
 This patch changes the media manager dialog.
 
 And while it seems to work for me I have two questions, one
 major, one minor.
 
 The "close" method just had a "self.assistant.hide()" (and
 no call to something-close).  So I left the "hide"
 although
 I wondered why it was there, since it seemed to me that
 method wasn't hit until things were finished.  I added
 a
 "ManagedWindow.close(self)" too, to formally close things,
 although I wondered when a "close" happened, before.
 
 I am wondering whether there was no "close" because there
 are DB transactions which happen in the media manager and
 perhaps you don't want to "close" things until they finish?
 But while I am not an expert in DB transactions it looks to
 me like they are finished by the time the "close" method is
 called (by the user).  (It's in a "with" with "batch"
 set to
 True, for instance.)  So that's my major question.
 
 (I don't have media in my personal database and I certainly
 don't know of a tree which has lots and lots of them, that
 I
 could use to test things, so perhaps some of you are better
 placed to test my proposed changes?)
 
 The minor question is that I can't seem to shrink the
 dialog
 very much, narrow it.  And in some other languages it's
 even
 worse, wider that is.  But that's beyond the scope of
 what
 I'm trying to accomplish.  I certainly plan to live
 with it
 the way it is now, since we have other "wide" dialogs (the
 Person editor and name-format dialog come to mind). 
 I'm
 just curious (since I don't know enough), whether it's
 possible to (somehow) trivially narrow it, wrap some line,
 or override the default width of some widget, etc.
 
 Thanks.
 
 -----La pièce jointe associée suit-----
 
 ------------------------------------------------------------------------------
 Developer Access Program for Intel Xeon Phi Processors
 Access to Intel Xeon Phi processor-based developer
 platforms.
 With one year of Intel Parallel Studio XE.
 Training and support from Colfax.
 Order your platform today. http://sdm.link/xeonphi
 -----La pièce jointe associée suit-----
 
 _______________________________________________
 Gramps-devel mailing list
 Gra...@li...
 https://lists.sourceforge.net/lists/listinfo/gramps-devel