From: Benny M. <ben...@gm...> - 2013-12-02 11:53:47
|
2013/12/2 Vassilii Khachaturov <vas...@ta...> > On 02.12.2013 11:38, Benny Malengier wrote: > >> But we WANT to be able to enter invalid dates. >> Gedcom import can create it, and transcribing sources can need it. >> The pink is sufficient warning to the user. >> > Since I had no reply, I've since 7198/7212 fix work based on the inputs > then available, and the current state of the matters is: > > 1) we allow people to have invalid dates > 1.1) in the date editor, but in text only, OK in the date editor is > disabled until you manually switch the date to text mode (7198); > 1.2) in the parent event editor -- as before; > 2) importing an invalid date auto-converts it to a text mode date, and > (where I had to write new code) emits a warning on the console (7212); > 3) you still get the pink in the parent event editor. > Ok, that seems ok. note that your bug number was in your subject, I read over that. Best is a link in the text when talking about a bug, like that lazy people like me can just click :-) As the bug makes clear, this is a bug fix. Allowing the OK, and explaining the user with an error dialog this must be text only date, would allow Aunt Marta to understand why she cannot click OK. Just a grayed out button seems bad for understanding what is wrong, it's like those html forms that don't allow you to go forward, and you keep changing the input of your tel number thinking that will be the problem, while it was because your wife has a - in her maiden name ... I can't try Gramps on this PC, saying in text only, but you need text mode.... why can you write text only if not in text mode ... Would have to try this evening to know. Benny |