From: Benny M. <ben...@gm...> - 2013-06-18 16:32:36
|
2013/6/18 John Ralls <jr...@ce...> > > On Jun 18, 2013, at 10:39 AM, Benny Malengier <ben...@gm...> > wrote: > > > > > 2013/6/18 Tim Lyons <guy...@gm...> > >> >> > >> > 1/ Source.title -> Source.sort_title. >> > Sort title will be a non editable field, automatically stored based on >> the >> > template and the attributes. We need it mainly for fast listview >> creation. >> > We could remove it entirely, but then we need to do a template loading >> -> >> > title construction from template, for every line in the source list >> view, >> > which I think we better do not do for performance. >> >> I don't think it is necessary to change the name of the field in the code. >> There is little chance of confusion in the code between Source.title and >> SrcAttributeType.SRCTEMPLATE.TITLE (not that the SrcAttributeType is >> accessed in quite that way). >> >> The names in the UI are a different matter - for the header of the >> listview >> column, something will be needed to distinguish it from the attribute. >> Perhaps something like "Combined Title" or "Consolidated Title" or >> "derived >> Title", or something similar. >> > > > This needs to be editable. Consider trying to find the right entry in the > Source > list when one has 50 entries named "Birth Certificate". > Are you sure? Or you use Church Record book, and that is the unique source, with birth certificates of people as sources indicated by date/page/id Or you make a source for every birth certificate (not what you are supposed to do, but understandable), in which case the title would probably contain the person born, or the website with the certificate, .... All things that make it unique when generated automatically. I don't mind keeping the title editable, it's at the moment programmed like that. Your reasoning for allowing it doesn't hold though in my opinion. Benny > > You could certainly fill in an initial value from the Title (or Author and > Title) > when first creating the Source, but let the user edit it and don't touch > it with > the template code if there's already a value in it. > > Regards, > John Ralls > > |