From: Enno B. <enn...@gm...> - 2013-03-25 12:22:36
|
Hi Paul, > OK, I have totally reverted the change to gen/plug/_pluginreg.py > I made in 21728. But I left the four other similar changes in. > So please test it again and if it still fails for you I'll revert them too. In trunk, Gramps starts OK now, so your reversions helped. > But either I am misunderstanding something -- which seems like > the most probably reason to me -- or else the idea that an open() > should be changed to an io.open() (so that the same line works in > both Python2 and Python3, without checking for sys.version_info[0] ) > needs some qualifying or adjusting. I think that the idea is OK, but you need to import some module to make sure that strings are always treated as unicode. This must be in the list archive somewhere. Without that import, I get this on exit: 2013-03-25 13:08:11.278: ERROR: grampsapp.py: line 114: Unhandled exception Traceback (most recent call last): File "/home/test/trunk/gramps/gui/viewmanager.py", line 1023, in quit self.__delete_pages() File "/home/test/trunk/gramps/gui/viewmanager.py", line 1316, in __delete_pages page.on_delete() File "/home/test/trunk/gramps/gui/views/listview.py", line 982, in on_delete PageView.on_delete(self) File "/home/test/trunk/gramps/gui/views/pageview.py", line 526, in on_delete self.sidebar.on_delete() File "/home/test/trunk/gramps/gui/widgets/grampletbar.py", line 272, in on_delete self.__save() File "/home/test/trunk/gramps/gui/widgets/grampletbar.py", line 200, in __save fp.write(";; Gramplet bar configuration file" + NL) TypeError: must be unicode, not str Helge reported that too, and I know that it works OK in other places, like in grampletpane.py. It saves its gramplets in a similar way, using io.open and fp.write, and it does that without errors, but I haven't figured out the proper import module yet. regards, Enno |