Re: [Gramps-users] New Media Verify tool

[Helge.Herz <Hel...@we...>]

Nick,

all comments below (I tried also svn 1697):

Am 15.03.2013 18:59, schrieb Nick Hall:
> On 14/03/13 23:12, Helge.Herz wrote:
>> Nevertheless I have issues using  Gramps 3.4.2 from GrampsAIO64-3.4.1-1
>> on win7:
>> -  if the progess windows is behind the Gramps main window I can close
>> the Medi Verify Toll Window --> why doesn't run the progress window modal?
> I use the Gramps ProgressMeter class for the progress bars.  It doesn't
> have an option to make it modal.
It seems to me the ProgressMeter runs modal in relation to the main 
Gramps window. It's possible to close the MediaVery tool during 
ProgressMeter is still working.
The user may do this in such cases: Click on the MediaVerify window and 
the ProgessMeter will not shown in all cases the main window full 
overlaps the ProgessMeter window. As result the MediaVerify window is 
alone to see and durring 'generate' without any content. It seems to be 
come to the end of its work...
If one closes the MediaVerify tool in this moment and stops the 
ProgressMeter using cancel or waits until the end of the progessmeter:
370859: ERROR: gramps.py: line 105: Unhandled exception
Traceback (most recent call last):
   File 
"D:\GRAMPS\gramps34\gramps\gramps34\plugins\MediaVerify\MediaVerify.py", 
line 285, in generate_md5
     self.show_tabs()
   File 
"D:\GRAMPS\gramps34\gramps\gramps34\plugins\MediaVerify\MediaVerify.py", 
line 231, in show_tabs
     tab.hide()
AttributeError: 'NoneType' object has no attribute 'hide'

If  one does the same during 'verify' the result is as told last time:
>> In one case I got this:
>> 2067671: ERROR: gramps.py: line 105: Unhandled exception
>> Traceback (most recent call last):
>>      File
>> "D:\GRAMPS\gramps34\gramps\gramps34\plugins\MediaVerify\MediaVerify.py",
>> line 385, in verify_media
>>        self.show_tabs()
>>      File
>> "D:\GRAMPS\gramps34\gramps\gramps34\plugins\MediaVerify\MediaVerify.py",
>> line 231, in show_tabs
>>        tab.hide()
>> AttributeError: 'NoneType' object has no attribute 'hide'
> When do you get this error?
see above

A next issue resulting of the non modal ProgressMeter is one can start 
Verify and/or Generate and / or Fix etc. multiple times in parallel!
The users view may be the same as before: ProgressMeter behind main window.
I didn't try all combinations. And it may be dangerous running Verify 
and Fix in parallel.
Could be the progress bar a part of the MediaVerify window instead?
>> -  the double click to open a media file doesn't work for file names
>> having non-ascii (the default windows issue)
> I don't have any problems with non-ascii characters.  I use the same
> utility functions used in the media editor.
I still have this issue: using LANG=de_DE than the view for non-ascii 
characters is well, but I'm not able to open from MediaVerify.
I tried LANG=en_GB: non-ascii characters won't be shown correct (that's 
OK), to open also doesn't work.

Do you have an idea / hint how to debug?
>
>
>> -  I don't have sorted lists
> What happens when you click on a column heading?
Sorry, I didn't know this feature: After doing this it's well sorted. 
And also the Export is sorted in the same way than. Great.
So this isn't an issue any more.
>> - if I use the fix button the content of the Moved Files and Renamed 
>> Files should be marked as done or cleared 
> Yes, it is a good idea to provide feedback to the user.  I have made a
> change to clear the tab after the fix is run.
Works fine for me with svn 1697.
>> What is the difference between moved and renamed, or when will renamed
>> be used?
> There is no difference - moved files and renamed files are listed in the
> "Moved Files" tab.
Should the mouse over text be changed to "moved or renamed files" and 
the notepad tab should have the same information?
I know it seems to be extremely fussy, bit I did work for a longer time 
for usability definitions and checks. And I always tend to to want to 
see what I get. Following the current mouse over I did search for for 
'renamed' because there is no result to see for this class of files.
>
>
> Nick.
About the updates in Gramps:
     MediaVerify.gpr.py tells in line 32 still:

    version = '1.0.2'

I don't know what version is right now. That's why I didn't change.
- Helge