From: Jérôme <rom...@ya...> - 2013-02-20 09:20:49
|
Only for info, some months ago, there was some testing and reviews on this addon: http://sourceforge.net/p/gramps-addons/code/1644/log/?path=/trunk/contrib/PlaceCompletion/PlaceCompletion.py I have added a small improvement/contribution for common place scheme used in France[1] on rev1299[2] and minor related fix, later. I also fixed[3] one issue with long & lat keys on rev1407 http://sourceforge.net/p/gramps-addons/code/1407/ [1] http://www.geneanet.org/forum/index.php?topic=435765.0 [2] http://gramps-addons.svn.sourceforge.net/viewvc/gramps-addons?view=revision&revision=1299 [3] http://www.gramps-project.org/bugs/view.php?id=5980 Le 18/02/2013 23:55, Benny Malengier a écrit : > > > > 2013/2/18 Nick Hall <nic...@ho... <mailto:nic...@ho...>> > > On 18/02/13 09:22, Benny Malengier wrote: > > The regex was based on the files as they looked like some years > ago. Every small change since will cause problems. > If you add a new regex, rename the old one to "blablabla- pre > 2011 version", as people might have downloaded the set and use > it since. > > > There were two problems: > > 1. Some extra columns have been added to the end of the record, and > the regexp matched the end of line. Removing the match on the last > few columns should work for both new and old format files. > > 2. The match for latitude and longitude assumed that the fields > would start with +, - or a digit. Some fields started with a > decimal point. Changing this should not affect matching against the > old file format either (and may improve it). > > I don't actually know what the old file format looked like or when > it changed though. > > > You are right that those changes should work ok, so no need to support > the old specific then. Keep it as a comment in the code I would say. > I downloaded the formats when I wrote this tool so many years ago. But > that was on another PC which since crashed it's hard disk, so I will not > have them around anymore (perhaps on an old backup, but not worth going > to the attic for that I think). > > Benny > > > Nick. > > > > > ------------------------------------------------------------------------------ > The Go Parallel Website, sponsored by Intel - in partnership with Geeknet, > is your hub for all things parallel software development, from weekly thought > leadership blogs to news, videos, case studies, tutorials, tech docs, > whitepapers, evaluation guides, and opinion stories. Check out the most > recent posts - join the conversation now. http://goparallel.sourceforge.net/ > > > > _______________________________________________ > Gramps-users mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-users > |