Re: [Gramps-devel] Gtk3 problems with ValidatedComboEntry on ubuntu 12.10

[Benny M. <ben...@gm...>]

2012/10/10 Serge Noiraud <Ser...@fr...>

>  Le 10/10/2012 21:35, Benny Malengier a écrit :
>
>
>
> 2012/10/10 Serge Noiraud <Ser...@fr...>
>
>>  Le 08/10/2012 14:18, Benny Malengier a écrit :
>>
>>
>>
>> 2012/10/8 Serge Noiraud <Ser...@fr...>
>>
>>>  Le 07/10/2012 20:32, Benny Malengier a écrit :
>>>
>>> If you have time, feel free to change it already. I won't have time the
>>> coming days :-)
>>>
>>>
>>>  Perhaps I found the problem :
>>>
>>> Questions : how do you launch in trunk ?
>>>
>>> If I do :
>>> $ sudo python setup.py install
>>> $ gramps
>>>
>>>    The problem is in setup.py :
>> I have a patch but there is perhaps another solution.
>>
>> Index:
>> setup.py
>>
>> ===================================================================
>>
>> --- setup.py    (révision
>> 20548)
>>
>> +++ setup.py    (copie de
>> travail)
>>
>> @@ -215,9 +215,9
>> @@
>>
>>
>> '''
>>
>>      filename = os.path.join(build_scripts,
>> 'gramps')
>>      f_out = open(filename,
>> 'w')
>>
>> -    f_out.write('#!
>> /bin/sh\n')
>>
>> -    f_out.write('export GRAMPSDIR=%sgramps\n' %
>> install_cmd.install_lib)
>> -    f_out.write('exec %s -O $GRAMPSDIR/gramps.py "$@"\n' %
>> sys.executable)
>> +    f_out.write('#!/usr/bin/env
>> python\n')
>>
>> +    f_out.write('import gramps.grampsapp as
>> app\n')
>> +
>> f_out.write('app.main()\n')
>>
>>      f_out.close()
>>
>
> I think this should be removed. We don't want a gramps file there, do we?
> There is /usr/bin/gramps already, why would we need another gramps?
>
> This is where this file is created. Then install copy it in /usr/bin ou
> /usr/local/bin depending on prefix
>

Can't look at it now, but that is what gramps.sh.in is for.
We don't need gramps.sh.in and some code in setup.py, so one should be
deprecated, and the code we want should be the one as now in gramps.sh.in
As gramps.sh is created in trunk, we can just copy gramps.sh, instead of
writing a file in setup.py

Do you have time to fix that? If not, create a bug ticket and put it on the
roadmap for trunk as a blocker for release.

Benn

>
>
> Benny
>
> ...
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> Gramps-devel mailing list
> Gra...@li...
> https://lists.sourceforge.net/lists/listinfo/gramps-devel
>
>