Re: [Gramps-devel] GEDCOM: name types

[Nick H. <nic...@ho...>]

Gabriel,

Thanks for the patch.

Tim is looking at the Gedcom Import/Export at the moment so he will be 
in a good position to look at this.  It looks OK to me though, but I 
have a couple of comments.

Should we be using TYPE rather than _TYPE on the export?

PERSONAL_NAME_STRUCTURE:=
n NAME <NAME_PERSONAL>
+1 TYPE <NAME_TYPE>
+1 <<PERSONAL_NAME_PIECES>>
+1 FONE <NAME_PHONETIC_VARIATION>
+2 TYPE <PHONETIC_TYPE>
+2 <<PERSONAL_NAME_PIECES>>
+1 ROMN <NAME_ROMANIZED_VARIATION>
+2 TYPE <ROMANIZED_TYPE>
+2 <<PERSONAL_NAME_PIECES>>

It is neater to write:

if line.data in ("_OTHN", "_AKA"):

rather than

if line.data == "_OTHN" or line.data == "_AKA":

Regards,

Nick.


On 01/03/12 07:03, Gabriel Burca wrote:
> Here's an updated patch to both import and export name types. According
> to one resource (http://www.gencom.org.nz/GEDCOM_tags.html) it looks
> like _MARN and _MARNM are equivalent. With this patch, _MAR, _MARN, and
> _MARNM are treated the same by GRAMPS.
>
> I have a file generated by "Genbox" from "Thoughtful Creations" that
> exports name types as:
>
> 0 @I46@ INDI
> 1 NAME Virginia /Jones/
> 1 NAME Virginia /Smith/
> 2 _TYPE _MARN
>
> The patch also adds handling for this format.
>
>
>
> ------------------------------------------------------------------------------
> Virtualization&  Cloud Management Using Capacity Planning
> Cloud computing makes use of virtualization - but cloud computing
> also focuses on allowing computing to be delivered as a service.
> http://www.accelacomm.com/jaw/sfnl/114/51521223/
>
>
> _______________________________________________
> Gramps-devel mailing list
> Gra...@li...
> https://lists.sourceforge.net/lists/listinfo/gramps-devel