From: Adam S. <ad...@pp...> - 2012-01-03 12:30:26
|
My patch just fixes the problem of adding an image to the hierarchical list to be processed. Maybe the code for actually inserting the image has issues? I can verify that the table and image are at the "same level" (that is, children of the same parent object). If they are NOT at the same level, maybe that explains the problem. On Fri, 2011-12-30 at 14:29 +0000, Nick Hall wrote: > Adam, > > Thanks for the patch. It is a good start but doesn't look right at the > moment. The picture should be printed to the right of the table. > > The cairo drawing and pagination assumes that each element will be > printed below the previous one. We need to think about how to print > elements side-by-side. > > More comments below - > > > On 29/12/11 12:37, Adam Stein wrote: > > I've added info to Jerome's bug tracker (5434). I tried inlining the > > patch, but lines got wrapped. I wound up uploading the patch to the bug > > tracker. > > > > For anybody who's interested in what changed, there are 3 changes in the > > patch file (only src/plugins/lib/libcairodoc.py is affected): > > > > 1) patch around line 376 > > > > Added a loop to process an element's children if the element isn't a > > table (the table element processes it's own children -- table rows). > > This solves the problem when a paragraph has children, like an image. > > > > This would be better in the draw method of GtkDocParagraph. > > > > 2) patch around line 392 > > > > Modified the paragraph element to accept images as children so that the > > image can be added to a paragraph. > > Yes. The ODF output allows images within paragraphs so we will need > this. The paragraph style is used as the caption style for the image. > > > > 3) patch around line 414 > > > > While this isn't specifically to fix the image problem, I noticed I had > > a problem with multi-line captions. This fixes that problem for PDF > > files (I uploaded a patch for other backend formats in another bug > > tracker report, but that patch hasn't been committed to trunk yet). > > > > This would be better in a separate patch. If you let me know the bug > number, I'll have a look at it for you. > > Nick. > > > > Try it out and tell me what you think. If there are no problems, > > somebody can commit to trunk. > > > > On Thu, 2011-12-29 at 00:11 +0000, Paul Franklin wrote: > >> On 12/28/11, Adam Stein<ad...@pp...> wrote: > >>> Which bug tracker is Jerome's? ... > >> http://www.gramps-project.org/bugs/view.php?id=5434 > >> > >>> I only suggested listing it here is because (a) it's small and (b) > >>> allows the people looking at the issue to quickly see if it meets the > >>> need before releasing it to a bug tracker or committing to trunk. > >> I like the idea of getting comments, from the senior developers. > >> > >> Why don't you mail it inline, in that case? > > > ------------------------------------------------------------------------------ > Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex > infrastructure or vast IT resources to deliver seamless, secure access to > virtual desktops. With this all-in-one solution, easily deploy virtual > desktops for less than the cost of PCs and save 60% on VDI infrastructure > costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox > _______________________________________________ > Gramps-devel mailing list > Gra...@li... > https://lists.sourceforge.net/lists/listinfo/gramps-devel -- Adam Stein @ HCL America Inc. Email: ad...@pp... Disclaimer: Any/All views expressed here have been proven to be my own. [http://www.csh.rit.edu/~adam/] |