From: Doug B. <dou...@gm...> - 2011-10-09 20:24:41
|
On Sun, Oct 9, 2011 at 1:26 PM, jerome <rom...@ya...> wrote: ... > Note, looking at changes, I see that there is no "update() call" on sources handling! > > 285 if source_len > 0: > 286 self.g.write(" <sources>\n") > 287 for handle in sorted(self.db.get_source_handles()): > 288 source = self.db.get_source_from_handle(handle) > 289 self.write_source(source,2) > 290 self.g.write(" </sources>\n") > > why ? My changes didn't touch that [1], but it does look like you are correct that a few of the items don't update the status. Feel free to fix that... you should make sure that the updater total count is correct. [1] - http://gramps.svn.sourceforge.net/viewvc/gramps/trunk/src/plugins/export/ExportXml.py?r1=18265&r2=18264&pathrev=18265 >> 3) Change example Gramps XMLs in trunk to be in handle-order for regression testing. > > True, we must make a new "proper generation" (import/export). > > Note, attributes' order into elements or element order might be different (but not important) on previous revisions because it was sometimes really hard to check missing data on example.gramps without this "idempotent" stage... > > http://www.gramps-project.org/bugs/view.php?id=4220 If you can find a test method that produces different ordering results, I can try to fix it. Otherwise, it is hard to find the issue. Thanks! -Doug > > Thank you. > Jérôme |