Re: [Gramps-devel] Accidental bug for custom filter filename?

[Nick H. <nic...@ho...>]

On 03/10/11 16:48, Jérôme wrote:
> Adam,
>
>
>> Is this a temporary thing for this version?
> No, I guess it will be the same for all versions and next major releases.

Correct.  Each major version will store the custom_filters.xml file in 
the version sub-directory.

The format of this file may change slightly between major versions.


>> why does subversion have the original location and not this modified location?
> trunk ?
> I suppose you did not rebuild const.py ?
> const.py.in =>  const.py
>
>> I couldn't tell if this change was only for v3.3.1 and not future versions.
> In fact, Nick asked how this 'arguments list' should migrate after a
> major update like done between 3.2.6 to 3.3.
>
> Name and place arguments have been improved and modified.
> And to use 'old' arguments with new model could generate some strange
> issues (same possible problem with 'report_options.xml' and
> 'tool_options.xml')... To upgrade content of previous file seems not to
> be possible and I guess to use a new class name will also lose the
> previous filter rules ?
>
> Just replace the previous './gramps/custom_filters.xml' to
> './gramps/gramps33/custom_filters.xml' if you know that you do not have
> filter rules on names or place location.

Yes, this is the best way to upgrade.  Gramps will attempt to upgrade 
the file if filter parameters have changed between versions.


> Note, I made tests on these rules during developement (trunk, some
> months ago) and I only had warnings about arguments migration attempt
> ... I do not know where/when this issue on arguments list came from!
>
> We already got these type of problem in the past, see
> 'old_names_2_class()' under Filters/_FilterParser.py !
>
>
> PS: should 'report_options.xml' and 'tool_options.xml' not use the same
> way ?
>
>

Possibly, this may be useful in the future but doesn't cause a problem 
at the moment.

Nick.


> Jérôme
>
> Adam Stein a écrit :
>> That explains why v3.3.1 has a different location.  Is this a temporary
>> thing for this version?  If not, why does subversion have the original
>> location and not this modified location?  I couldn't tell if this change
>> was only for v3.3.1 and not future versions.
>>
>> On Mon, 2011-10-03 at 16:20 +0200, Jérôme wrote:
>>> Cause of "5012: 3.2.5 filter(s) cause 3.3 to crash":
>>> http://www.gramps-project.org/bugs/view.php?id=5012
>>>
>>> "custom filter configuration file location into the version
>>> sub-directory. The filter parser will now attempt to upgrade an old
>>> version of the file. If you want to use your old filters you will have
>>> to copy the configuration file."
>>>
>>> http://www.gramps-project.org/bugs/view.php?id=5012#c20912
>>>
>>>
>>> Regards,
>>> Jérôme
>>>
>>> Adam Stein a écrit :
>>>> This new version (v3.3.1) has this set for the custom filter filename:
>>>>
>>>> 	CUSTOM_FILTERS = os.path.join(VERSION_DIR, "custom_filters.xml")
>>>>
>>>> Previous versions AND the version in subversion have this:
>>>>
>>>> 	CUSTOM_FILTERS = os.path.join(HOME_DIR, "custom_filters.xml")
>>>>
>>>> Obviously, nobody is going to be able to get to their custom filters in
>>>> v3.3.1.  Which is correct?
>>>>
>
> ------------------------------------------------------------------------------
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2dcopy1
> _______________________________________________
> Gramps-devel mailing list
> Gra...@li...
> https://lists.sourceforge.net/lists/listinfo/gramps-devel