Re: [Gramps-devel] Restructured NarrativeWeb.py

[W. T. K. <wk...@dr...>]

On Sat, Sep 03, 2011 at 01:01:43AM -0700, Rob Healey wrote:
> On Fri, Sep 2, 2011 at 8:11 AM, W. Trevor King <wk...@dr...> wrote:
> > On Mon, Aug 22, 2011 at 06:47:05PM -0400, Doug Blank wrote:
> > > This looks like a great cleanup, which can only help, I think. Of course,
> > if this is a one-time contribution is has limited usefulness.
> >
> > This doesn't make sense to me.  If it helps, it helps :p.  Hopefully my
> > changes aren't *so* confusing that any other dev can't build on them...
> 
> You are correct for the most part, but there is a learning curve on
> NarrativeWeb and Gramps in general, I think at least!

Yup, I had to get pretty far into my rewrite before I understood what
was going on ;).  I think the standardized classes (e.g. BaseListPage)
and trimmed down BasePage will make the learning curve more gentle for
future newbies.  Of course, it adds an additional learning curve for
current devs who had already figured out the old system, but I don't
think any of my architecture changes were so big that they won't catch
on fast.

> > > If you were interested, I'd certainly like to work with you to make your
> > refactor (applied to trunk) as the first step in bigger plans.
> >
> 
> I would also love to see if we could get your changes into trunk as soon as
> possible, like yesterday...

Heh, sorry :p.  Maybe by the end of next week?  See below.

> > I've been looking through the recent changes to NarrWeb in the trunk, and I
> > they don't merge cleanly into mine.  Here's my summary of what we've each
> > done:
> >
> >  Me:
> >    1. Update to mapstraction to v2.0.16.
> >    2. Restructure NarrWeb code
> >      2a. Removed globals like place_lat_long, _individuallist
> >      2b. Trimmed down BasePage
> >      2c. Added _get_section framework for filling in page content
> >      2d. Added PageName, BaseSimplePage, BaseListPage, BaseDetailPage,
> >          BaseMapPage, and _PersonBox to consolidate common page-creation
> >          features.
> >      2e. Added new page types: FamilyListPage, FamilyPage, AddressListPage.
> >      2f. Consolidated linking and naming into NavWebReport methods
> >    3. Assorted coding cleanups.
> >  Trunk:
> >    1. Removed mapstraction in favor of direct OpenStreetMap/GoogleMap/...
> >    2. Fix gui/gen source of MenuReportOptions import.
> >    3. Assorted coding and HTML cleanups.
> >    4. Add FamilyListPage and FamilyPage.
> >    5. Add thumbnail preview page.
> >
> > Did I miss any?  What features should be pulled into my branch?
> 
> When you mentioned, what should be pulled in to your branch of trunk?  I
> would say all of them should be pulled in to it!  I am not sure why there is
> even a question on this one?

The problem is that few of the patches apply cleanly, since my rewrite
tweaked so much.  For example, we now have two separate FamilyListPage
implementations.  Which one to pick?  For the other changes, it takes
time for me to figure out exactly what the changes did and determine
if they still apply to my branch.  I was basically looking to see if
anyone felt that some trunk changes were sufficiently minor for me to
drop them without combing through the related patch(es).  Apparently
not ;).  I'll be digging through the patches as time permits, and I'll
post with any problems I run into...

> > On Tue, Aug 23, 2011 at 05:27:11PM -0400, Doug Blank wrote:
> > > The .ini could actually be a bit of python code, that could set the
> > appropriate options and run the report.
> 
> I actually like Doug's idea!  The .ini files are not meant to be edited by
> the normal/ casual user!  All of the options are defined inside of Gramps...

But then the user has to know where the .ini files are stored.  What's
wrong with the current:
  python src/gramps.py --open MY_DB --action report --options name=navwebpage

> > On Tue, Aug 23, 2011 at 11:16:52PM -0700, Rob Healey wrote:
> > I just ran your report and your FamilyListPage is similar to mine.  We can
> > use whichever layout people like better...
> 
> I just ran the git clone command to download and checkout your branch, and I
> do not see a FamilyListPage or FamilyPage...

That's odd.  They've been there since:

  commit 370fef564ba640999cdb13a3afef3e002ef22a9f
  Author: W. Trevor King <wk...@dr...>
  Date:   Sun Aug 21 09:42:58 2011 -0400

    Restructure NarrativeWeb.py.

What version are you looking at?

> I also do not see my thumbnail preview page either!

I haven't merged that part yet.

> Trevor, we are here to help, and to work together...  I hope that we will
> continue to see you here?

Yup.  Eventually we'll get this thing beaten into shape ;).

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy